chore(notebook): dead code removal from local-first migration#595
Merged
chore(notebook): dead code removal from local-first migration#595
Conversation
…tialization This PR simplifies the Tauri relay architecture (issue #556): Task 1: Remove NotebookState fallback branches - Remove fallback in get_preferred_kernelspec() - now requires daemon - Remove fallback in verify_notebook_trust() - now requires daemon Keeps mutation-based cell initialization: - The initial_cells via handshake approach was reverted because: 1. Handshake has 64 KiB frame limit - large notebooks would fail 2. Architecturally wrong - daemon should determine cell seeding - Mutations (add_cell, update_source, set_metadata) remain for now - NotebookState.path sync restored for session restore compatibility
9156f52 to
cf05e5b
Compare
rgbkrk
pushed a commit
that referenced
this pull request
Mar 8, 2026
…601) Update both audit documents to cover new protocol surfaces introduced by the daemon-owned notebook loading infrastructure (OpenNotebook and CreateNotebook handshakes) and dead code removal from the local-first migration. New findings: - OpenNotebook accepts arbitrary file paths for reading (medium) - Error paths drain unbounded reader data (medium) - do_initial_sync uses 100ms timeout for convergence (medium) - CreateNotebook runtime field not validated (low) - load_notebook_from_disk has no file size limit (low) Positive changes noted: - Trust verification fallback branches removed (#595) - Daemon-side doc population reduces CRDT merge complexity - Atomic check-and-load prevents duplicate cell population - Client-side protocol version validation in new handshakes https://claude.ai/code/session_01ToG68d36uTowAeraL5CF7R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dead code cleanup from the local-first WASM migration. Addresses #596 and #597.
Removed fallback branches (#597)
verify_notebook_trust()- now requires daemon connection, no silent fallbackDeleted dead code (#596)
get_preferred_kernelspecTauri command - zero frontend callers (frontend reads from WASM doc viauseSyncExternalStore)formatmodule (202 lines) - zero callers after feat(runtimed): format-on-execute, remove Tauri format_cell command #563 (formatting now lives in daemon)What was kept
NotebookState.pathsync insave_notebook_as(required for session restore)initialize_notebook_synccreate_notebook_window()andrun()startupCloses #596
Closes #597