Move some core type into internal & migrate to slnx + Check unit test#881
Closed
304NotModified wants to merge 6 commits intonsubstitute:mainfrom
Closed
Move some core type into internal & migrate to slnx + Check unit test#881304NotModified wants to merge 6 commits intonsubstitute:mainfrom
304NotModified wants to merge 6 commits intonsubstitute:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #880 + a check unit test
@Romfos Unfortunately I cannot push to your branch, but I think we should not use .Internal types in the public API.
That's pretty hard to check, So I wrote some test for it. Those fail on multiple methods and properties. Could you please check the test results?