Move some core type into internal & migrate to slnx#880
Move some core type into internal & migrate to slnx#880Romfos wants to merge 5 commits intonsubstitute:mainfrom
Conversation
| --> | ||
|
|
||
| The `Throws` and `ThrowsAsync` helpers in the `NSubstitute.ExceptionExtensions` namespace can be used to throw exceptions when a member is called. | ||
| The `Throws` and `ThrowsAsync` helpers in the `NSubstitute.Extensions` namespace can be used to throw exceptions when a member is called. |
There was a problem hiding this comment.
Is this some other change, as it isn't the internal namespace?
Are more namespaces changed in this PR?
|
Initially the The MR looks good, will approve pending feedback on @304NotModified's comments. 👍 |
|
@dtchepak |
Haha, yes, sorry. I do a lot with gitlab where they're known as Merge Requests. |
|
@304NotModified thank you for your feedback. I'm afraid that this approach will make more problems then solve Lets save status quo for now and don't do anything with it |
Changes:
This PR is a follow up for discussion #869 and alternaltive solution when we don't what make these types "true" internal\sealed but still want to logically separate these types
Core types that are still "public" core namespace:
Related #830