Merged
Conversation
Body is a part of binary which is always calculated for cache lookup.
Also, body is used to verify token signature. Previously, service
allocated two token buffers per-request while body was present in both
of them. Now service uses only one buffer.
```
goos: linux
goarch: amd64
pkg: github.com/nspcc-dev/neofs-node/pkg/services/object/acl/v2
cpu: Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz
│ old │ new │
│ sec/op │ sec/op vs base │
SessionTokenVerification-8 83.14µ ± 0% 82.97µ ± 1% ~ (p=0.315 n=10)
│ old │ new │
│ B/op │ B/op vs base │
SessionTokenVerification-8 3.984Ki ± 0% 2.773Ki ± 0% -30.39% (p=0.000 n=10)
│ old │ new │
│ allocs/op │ allocs/op vs base │
SessionTokenVerification-8 58.00 ± 0% 43.00 ± 0% -25.86% (p=0.000 n=10)
```
Refs #3407.
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Same as 4454d1d. ``` goos: linux goarch: amd64 pkg: github.com/nspcc-dev/neofs-node/pkg/services/object/acl/v2 cpu: Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz │ old │ new │ │ sec/op │ sec/op vs base │ BearerTokenVerification-8 83.56µ ± 14% 82.49µ ± 2% ~ (p=1.000 n=10) │ old │ new │ │ B/op │ B/op vs base │ BearerTokenVerification-8 3.461Ki ± 0% 2.664Ki ± 0% -23.02% (p=0.000 n=10) │ old │ new │ │ allocs/op │ allocs/op vs base │ BearerTokenVerification-8 52.00 ± 0% 42.00 ± 0% -19.23% (p=0.000 n=10) ``` Refs #3407. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Same as 4454d1d. ``` goos: linux goarch: amd64 pkg: github.com/nspcc-dev/neofs-node/pkg/services/container cpu: Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz │ old │ new │ │ sec/op │ sec/op vs base │ SessionTokenVerification-8 87.69µ ± 12% 80.44µ ± 2% -8.27% (p=0.001 n=10) │ old │ new │ │ B/op │ B/op vs base │ SessionTokenVerification-8 3.250Ki ± 0% 2.445Ki ± 0% -24.76% (p=0.000 n=10) │ old │ new │ │ allocs/op │ allocs/op vs base │ SessionTokenVerification-8 48.00 ± 0% 39.00 ± 0% -18.75% (p=0.000 n=10) ``` Closes #3407. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
1a73b55 to
7312bf4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3778 +/- ##
==========================================
+ Coverage 25.64% 25.66% +0.01%
==========================================
Files 657 658 +1
Lines 42129 42165 +36
==========================================
+ Hits 10805 10822 +17
- Misses 30344 30362 +18
- Partials 980 981 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.