-
Notifications
You must be signed in to change notification settings - Fork 50
Closed
Labels
I4No visible changesNo visible changesS4RoutineRoutineU4Nothing urgentNothing urgentenhancementImproving existing functionalityImproving existing functionalityhelp wantedExtra attention is neededExtra attention is neededneofs-storageStorage node application issuesStorage node application issuesperformanceMore of something per secondMore of something per second
Description
Is your feature request related to a problem? Please describe.
full bearer/session token BLOB is a concatenation of 2 fields:
- body
- signature
currently, SN calculates it twice per-request:
- to access token cache
- to check the signature
body participates in both cases, but encoded twice
Describe the solution you'd like
marshal token once and reuse
Describe alternatives you've considered
originally, token comes in a binary format over gRPC. Then it's decoded to generated proto struct instance by gRPC lib functions, then we encode it again. So, we have extra decode-to-encode round. The best way would be:
- take token BLOB
- check everything needed with it
- decode
this is the most efficient approach. At the same time, it is quite challenging according to the API of used gRPC lib. This improvement is not limited to tokens and can be extended to many other cases
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
I4No visible changesNo visible changesS4RoutineRoutineU4Nothing urgentNothing urgentenhancementImproving existing functionalityImproving existing functionalityhelp wantedExtra attention is neededExtra attention is neededneofs-storageStorage node application issuesStorage node application issuesperformanceMore of something per secondMore of something per second