Improve object deletion via control service#3727
Merged
roman-khimov merged 4 commits intomasterfrom Dec 10, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3727 +/- ##
=======================================
Coverage 26.87% 26.88%
=======================================
Files 658 658
Lines 41828 41861 +33
=======================================
+ Hits 11242 11254 +12
- Misses 29549 29568 +19
- Partials 1037 1039 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
51e89a5 to
2b68316
Compare
2b68316 to
7f899a5
Compare
cthulhu-rider
approved these changes
Dec 10, 2025
carpawell
approved these changes
Dec 10, 2025
Member
Author
|
Tests are subject to nspcc-dev/neofs-testcases#1236 |
7f899a5 to
31f3ae4
Compare
Obsolete since fa9347b, t.TempDir() solves the problem completely. Signed-off-by: Roman Khimov <roman@nspcc.ru>
This actually reveals a bug in TestErrorReporting, corrupted directories were never properly removed. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Delayed removal incurs some additional penalty (writing to metabase) and also can leave the object in storage for unknown time (GC can be busy). Control service is used only for emergency cases where direct removal is likely to be more beneficial. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Drop useless code. Signed-off-by: Roman Khimov <roman@nspcc.ru>
31f3ae4 to
a4377ba
Compare
Member
Author
|
Fixed CHANGELOG conflict after #3726. |
This was referenced Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.