sn: report at random time within report window if NM is empty#3726
Merged
roman-khimov merged 2 commits intomasterfrom Dec 10, 2025
Merged
sn: report at random time within report window if NM is empty#3726roman-khimov merged 2 commits intomasterfrom
roman-khimov merged 2 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3726 +/- ##
==========================================
- Coverage 26.88% 26.88% -0.01%
==========================================
Files 658 658
Lines 41825 41824 -1
==========================================
- Hits 11246 11244 -2
Misses 29544 29544
- Partials 1035 1036 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Dec 9, 2025
Also, drop reporting with minimal 1-second offset, that does not work in practice. Closes #3714. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
169969c to
a1d5127
Compare
One-time log at start that explains when SN's reports to expect at, useful in debug. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Member
Author
|
Changed timer's multiplier log too, was sad when could not find this info with DEBUG logs. |
Member
|
Looks like quota tests need to be adjusted again, file an issue for that. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, drop reporting with minimal 1-second offset, that does not work in practice. Closes #3714.