Skip to content

Synchronous container operations#3711

Merged
cthulhu-rider merged 3 commits intomasterfrom
container-async-await
Dec 5, 2025
Merged

Synchronous container operations#3711
cthulhu-rider merged 3 commits intomasterfrom
container-async-await

Conversation

@cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider force-pushed the container-async-await branch 2 times, most recently from 3878114 to 14e3d70 Compare December 4, 2025 10:56
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 8.00000% with 115 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.86%. Comparing base (af84826) to head (d73cb1c).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
pkg/morph/client/notary.go 0.00% 46 Missing ⚠️
pkg/morph/client/static.go 0.00% 16 Missing ⚠️
cmd/neofs-node/container.go 0.00% 15 Missing ⚠️
pkg/morph/client/container/put.go 0.00% 11 Missing ⚠️
pkg/services/container/server.go 52.63% 9 Missing ⚠️
pkg/morph/client/container/delete.go 0.00% 8 Missing ⚠️
pkg/morph/client/container/eacl_set.go 0.00% 8 Missing ⚠️
cmd/neofs-cli/modules/container/create.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3711      +/-   ##
==========================================
- Coverage   26.87%   26.86%   -0.01%     
==========================================
  Files         658      658              
  Lines       41808    41844      +36     
==========================================
+ Hits        11235    11242       +7     
- Misses      29536    29567      +31     
+ Partials     1037     1035       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthulhu-rider cthulhu-rider marked this pull request as ready for review December 4, 2025 11:07
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Follow nspcc-dev/neofs-api#338.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Since nspcc-dev/neofs-api#338, these requests
are handled in async/await manner server-side. This makes CLI to catch
new status and behave exactly like before.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider merged commit 5744113 into master Dec 5, 2025
20 of 22 checks passed
@cthulhu-rider cthulhu-rider deleted the container-async-await branch December 5, 2025 14:04
cthulhu-rider added a commit that referenced this pull request Mar 19, 2026
Container ops are synchronous since #3711.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants