Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3679 +/- ##
==========================================
+ Coverage 27.34% 27.36% +0.02%
==========================================
Files 658 658
Lines 41693 41705 +12
==========================================
+ Hits 11400 11413 +13
- Misses 29229 29232 +3
+ Partials 1064 1060 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Roman Khimov <roman@nspcc.ru>
dc15a30 to
52c4cda
Compare
| switch { | ||
| case errors.Is(err, sdkstatus.ErrServerInternal): | ||
| code = internal | ||
| hide = true // Everything relevant is printed by commands already. |
Contributor
There was a problem hiding this comment.
shouldn't this be for Incomplete case?
We have some data in this case that is printed, so we don't need error output, but we still need to return proper exit code. Signed-off-by: Roman Khimov <roman@nspcc.ru>
e0fc6ac wasn't sufficient, we need more data in messages returned. Signed-off-by: Roman Khimov <roman@nspcc.ru>
An omission of #3606. Signed-off-by: Roman Khimov <roman@nspcc.ru>
52c4cda to
5649499
Compare
cthulhu-rider
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.