Skip to content

Fix container session cache#3526

Merged
roman-khimov merged 2 commits intomasterfrom
bugfix/token-caches
Aug 13, 2025
Merged

Fix container session cache#3526
roman-khimov merged 2 commits intomasterfrom
bugfix/token-caches

Conversation

@cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider commented Aug 13, 2025

special thanks to @smallhive

@codecov
Copy link

codecov bot commented Aug 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.54%. Comparing base (9a26745) to head (d75a96d).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/container/server.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3526   +/-   ##
=======================================
  Coverage   23.54%   23.54%           
=======================================
  Files         669      669           
  Lines       50256    50248    -8     
=======================================
- Hits        11834    11833    -1     
+ Misses      37507    37502    -5     
+ Partials      915      913    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov roman-khimov added this to the v0.48.3 milestone Aug 13, 2025
@cthulhu-rider
sn/container: Fix caching request-dependent session errors
a79c544 
Similar to 90a7be8.

As a bonus, this deduplicates container relation check.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
sn/container: Deduplicate session issuer and container checks in DELETE
d75a96d 
Missed in 33aa2c7. Same actions are
already done in verifySessionTokenAgainstRequest().

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider marked this pull request as ready for review August 13, 2025 13:57
@roman-khimov roman-khimov merged commit fefd962 into master Aug 13, 2025
22 checks passed
@roman-khimov roman-khimov deleted the bugfix/token-caches branch August 13, 2025 14:16
cthulhu-rider added a commit that referenced this pull request Aug 13, 2025
@cthulhu-rider
sn/container: Fix caching request-dependent bearer errors
b6c75a2 
Similar to 90a7be8. Follow #3526.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this pull request Aug 13, 2025
@cthulhu-rider
sn/object: Fix caching request-dependent bearer errors
56abdc7 
Similar to 90a7be8. Follow #3526.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@carpawell carpawell carpawell approved these changes

@End-rey End-rey Awaiting requested review from End-rey End-rey is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.48.3

Development

Successfully merging this pull request may close these issues.

3 participants

@cthulhu-rider @roman-khimov @carpawell