Fix incorrect metabase garbage bucket setting on tombstone writing#3484
Merged
roman-khimov merged 2 commits intomasterfrom Jul 29, 2025
Merged
Fix incorrect metabase garbage bucket setting on tombstone writing#3484roman-khimov merged 2 commits intomasterfrom
roman-khimov merged 2 commits intomasterfrom
Conversation
1b00f26 to
040f61e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3484 +/- ##
==========================================
+ Coverage 23.34% 23.42% +0.07%
==========================================
Files 669 669
Lines 50249 50309 +60
==========================================
+ Hits 11731 11784 +53
- Misses 37602 37604 +2
- Partials 916 921 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
roman-khimov
left a comment
There was a problem hiding this comment.
We shouldn't have many of these, luckily. Just testnet.
Contributor
Author
yep, i also relied on this, otherwise the code'd have become more complicated with iterations |
Defect of 7105aff. Bucket key must be a full address, i.e. CID+OID, but was OID only. Add unit tests also. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
1894144 to
8a495b5
Compare
Completes 0d86d45 by correcting already recorded data at the init stage via migration to newly added metabase version. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
8a495b5 to
4337c67
Compare
roman-khimov
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from #3483