Conversation
Refs #3436. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3483 +/- ##
==========================================
- Coverage 23.15% 23.13% -0.02%
==========================================
Files 669 669
Lines 50251 50252 +1
==========================================
- Hits 11634 11628 -6
- Misses 37708 37713 +5
- Partials 909 911 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| garbageObjectsBKT := tx.Bucket(garbageObjectsBucketName) | ||
| err = garbageObjectsBKT.Put(target[:], zeroValue) | ||
| err = garbageObjectsBKT.Put(addressKey(oid.NewAddress(cID, target), make([]byte, addressKeySize)), zeroValue) |
There was a problem hiding this comment.
current state: lock object cannot be removed by gc because of incorrect gc bucket internals -> expired lock object was not removed from blobstor -> it was resynced from time to time -> correct TS cannot resync because of stuck LOCK
There was a problem hiding this comment.
BUT, when you created this issue, there was no such code at all, so... it looks like we have repeated the issue. i may expect the original issue to come back
There was a problem hiding this comment.
But looks like this affects every TS object, any deletion is problematic in that it breaks the metabase. If the metabase is broken, who is to repair it?
GC bucket requires full object address. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
287a91f to
a6020d6
Compare
|
Replaced by #3484. |
No description provided.