Merged
Conversation
1d0fa2f to
33fcbda
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #531 +/- ##
==========================================
- Coverage 63.87% 63.32% -0.56%
==========================================
Files 24 25 +1
Lines 2655 2773 +118
==========================================
+ Hits 1696 1756 +60
- Misses 953 1011 +58
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Oct 24, 2025
Implementation of nspcc-dev/neofs-contract#531. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Oct 24, 2025
Implementation of nspcc-dev/neofs-contract#531. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
4902125 to
416b710
Compare
416b710 to
28cfa44
Compare
contracts/balance/contract.go
Outdated
| } | ||
|
|
||
| func (t Token) transfer(ctx storage.Context, from, to interop.Hash160, amount int, innerRing bool, details []byte) bool { | ||
| func (t Token) _transfer(ctx storage.Context, from, to interop.Hash160, amount int, innerRing bool) bool { |
Member
There was a problem hiding this comment.
It MUST emit Transfer event per NEP-17.
Member
Author
There was a problem hiding this comment.
idk, i thought we had talked about it. ok, returned.
Member
There was a problem hiding this comment.
We talked about TransferX, that's a completely different thing that you can basically do whatever you want with. But balance is NEP-17 compatible so all token movements MUST produce Transfer event.
It will allow caching faults without panic from other contracts. Also, this make it closer to regular `Transfer`. Refs #493. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
None of NEP-17 contracts do it. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Required for billing. Also returns API back changed after #527 to be fully compatible with 0.24.0 release. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
This minimizes rounding error. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
28cfa44 to
3b50ed5
Compare
Use generated RPC bindings where appropriate. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Contracts have all necessary information for payment distribution. From now, payments are done with `PayForContainer` method that must be multi-signed by actual Alphabet. Payments are done using actual storage reports, basic income rate and network epoch. If payment cannot be done, container is marked as an unpaid one, corresponding `IsUnpaid` method for storage nodes is also included. Closes #493. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
3b50ed5 to
d6b31d3
Compare
roman-khimov
approved these changes
Nov 14, 2025
| case r.LatestEpoch == currEpoch-1: | ||
| size = r.LatestEpochAverageSize | ||
| default: | ||
| size = 0 |
Member
Author
There was a problem hiding this comment.
yeah, i know, just for explicitness
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 18, 2025
Implementation of nspcc-dev/neofs-contract#531. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 18, 2025
Implementation of nspcc-dev/neofs-contract#531. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 19, 2025
Implementation of nspcc-dev/neofs-contract#531. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 19, 2025
Implementation of nspcc-dev/neofs-contract#531. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 20, 2025
Implementation of nspcc-dev/neofs-contract#531. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.