container: make difference b/w Estimations and Reports#510
Merged
cthulhu-rider merged 1 commit intomasterfrom Aug 26, 2025
Merged
container: make difference b/w Estimations and Reports#510cthulhu-rider merged 1 commit intomasterfrom
cthulhu-rider merged 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
=======================================
Coverage 62.22% 62.22%
=======================================
Files 23 23
Lines 3328 3328
=======================================
Hits 2071 2071
Misses 1257 1257 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
approved these changes
Aug 26, 2025
End-rey
approved these changes
Aug 26, 2025
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Sep 10, 2025
Where will not be estimations in the next contract release. Refs nspcc-dev/neofs-contract#510. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Sep 11, 2025
Where will not be estimations in the next contract release. Refs nspcc-dev/neofs-contract#510. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Sep 12, 2025
Where will not be estimations in the next contract release. Refs nspcc-dev/neofs-contract#510. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Sep 15, 2025
Where will not be estimations in the next contract release. Refs nspcc-dev/neofs-contract#510. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Sep 16, 2025
Where will not be estimations in the next contract release. Refs nspcc-dev/neofs-contract#510. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Sep 17, 2025
Where will not be estimations in the next contract release. Refs nspcc-dev/neofs-contract#510. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Sep 17, 2025
Where will not be estimations in the next contract release. Refs nspcc-dev/neofs-contract#510. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Sep 19, 2025
Where will not be estimations in the next contract release. Refs nspcc-dev/neofs-contract#510. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Sep 22, 2025
Where will not be estimations in the next contract release. Refs nspcc-dev/neofs-contract#510. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 38ac6f6 there is clear difference b/w what is container's size estimation and what have been reported by nodes earlier, make it also clearer in contract's API. Refs #501.