object: Deprecate verification fields in GET and HEAD responses#334
Merged
roman-khimov merged 1 commit intomasterfrom Jun 20, 2025
Merged
object: Deprecate verification fields in GET and HEAD responses#334roman-khimov merged 1 commit intomasterfrom
roman-khimov merged 1 commit intomasterfrom
Conversation
3c0c21b to
c737990
Compare
The responses transmit object headers and, for GET, payload. Header may be checked using requested object ID. Payload checksum is stored inside the header. These mean that all data is verifiable and there is no need to calculate and transport additional signatures. This deprecates `verify_header` field in `GetResponse` and `HeadResponse` messages. Messages become more lightweight. Also, client and servers going to save CPU and memory. Refs nspcc-dev/neofs-node#3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
c737990 to
82f192a
Compare
carpawell
approved these changes
Jun 18, 2025
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Jun 19, 2025
They are deprecated since nspcc-dev/neofs-api#334. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Jun 19, 2025
They are deprecated since nspcc-dev/neofs-api#334. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 19, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 19, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 19, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 19, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
roman-khimov
approved these changes
Jun 20, 2025
Member
roman-khimov
left a comment
There was a problem hiding this comment.
OK, after some thinking and looking at https://github.com/neo-project/neofs-api-csharp (that uses 2.11) it seems like we can do this safely for this specific requests (which we care about most). Other requests can be considered later.
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Jun 20, 2025
They are deprecated since nspcc-dev/neofs-api#334. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 21, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 23, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 23, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 23, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 23, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 24, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 25, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Jun 25, 2025
Follow nspcc-dev/neofs-api#334. Refs #3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
that referenced
this pull request
Jan 26, 2026
Spread #334 to all RPC. Needed for nspcc-dev/neofs-node#3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
that referenced
this pull request
Jan 26, 2026
Spread #334 to all RPC. Needed for nspcc-dev/neofs-node#3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
that referenced
this pull request
Jan 26, 2026
Spread #334 to all RPC. Needed for nspcc-dev/neofs-node#3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
that referenced
this pull request
Feb 4, 2026
Spread #334 to all RPC. Needed for nspcc-dev/neofs-node#3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
that referenced
this pull request
Feb 4, 2026
Spread #334 to all RPC. Needed for nspcc-dev/neofs-node#3396. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.