config: upgrade NeoFS networks configuration#3833
Merged
roman-khimov merged 1 commit intomasterfrom Mar 19, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3833 +/- ##
==========================================
- Coverage 82.74% 82.44% -0.31%
==========================================
Files 338 341 +3
Lines 47484 47740 +256
==========================================
+ Hits 39293 39361 +68
- Misses 6561 6743 +182
- Partials 1630 1636 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
roman-khimov
left a comment
There was a problem hiding this comment.
Please add MaxValidUntilBlockIncrement: 8640 as well, that's the current config.
1-second blocks are used now and MaxValidUntilBlockIncrement is adjusted. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
0481089 to
dd20f76
Compare
Member
Author
|
Have you adjusted MaxTraceableBlocks as well? |
roman-khimov
approved these changes
Mar 19, 2025
Member
It's correct in current configs, 17280. |
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Mar 31, 2025
…works We use 1-second blocks in NeoFS mainnet/testnet for quite a long time, follow nspcc-dev/neo-go#3833. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Mar 31, 2025
Follow the nspcc-dev/neo-go#3833. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Mar 31, 2025
We use 1-second blocks in NeoFS mainnet/testnet for quite a long time, follow nspcc-dev/neo-go#3833. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Mar 31, 2025
Follow the nspcc-dev/neo-go#3833. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
15 tasks
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Mar 31, 2025
Follow the nspcc-dev/neo-go#3833. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Mar 31, 2025
Follow the nspcc-dev/neo-go#3833. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
shargon
added a commit
to neo-project/neo
that referenced
this pull request
Apr 1, 2025
* config: adjust MillisecondsPerBlock for FS networks We use 1-second blocks in NeoFS mainnet/testnet for quite a long time, follow nspcc-dev/neo-go#3833. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * ProtocolSettings: fetch MaxValidUntilBlockIncrement from config It's the protocol setting, hence it needs to be fetched from JSON node configuration file. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * config: adjust MaxValidUntilBlockIncrement for FS networks Follow the nspcc-dev/neo-go#3833. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com>
cschuchardt88
pushed a commit
to cschuchardt88/neo
that referenced
this pull request
Jun 8, 2025
* config: adjust MillisecondsPerBlock for FS networks We use 1-second blocks in NeoFS mainnet/testnet for quite a long time, follow nspcc-dev/neo-go#3833. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * ProtocolSettings: fetch MaxValidUntilBlockIncrement from config It's the protocol setting, hence it needs to be fetched from JSON node configuration file. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * config: adjust MaxValidUntilBlockIncrement for FS networks Follow the nspcc-dev/neo-go#3833. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1-second blocks are used now.