dbft: do not send PrepareRequest immediately after Recovery message#75
Merged
roman-khimov merged 1 commit intomasterfrom May 15, 2023
Merged
dbft: do not send PrepareRequest immediately after Recovery message#75roman-khimov merged 1 commit intomasterfrom
roman-khimov merged 1 commit intomasterfrom
Conversation
Member
Author
|
Draft until the neo-project/neo-modules#799 is resolved. |
We have timer, and we should follow it. Close #74. Signed-off-by: Anna Shaleva <anna@nspcc.ru>
945de8e to
5a6d1e5
Compare
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 75.05% 75.17% +0.11%
==========================================
Files 24 24
Lines 1311 1309 -2
==========================================
Hits 984 984
+ Misses 272 271 -1
+ Partials 55 54 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
approved these changes
May 15, 2023
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
May 16, 2023
Send PrepareRequest on timeout only: nspcc-dev/dbft#75.
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
May 16, 2023
Send PrepareRequest on timeout only: nspcc-dev/dbft#75. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have timer, and we should follow it. Close #74.