chore(module-federation): re-enable webpack-based react e2e tests (webpack 5.107.1 fix is live)#35764
Merged
Merged
Conversation
… that webpack 5.107.1 is out Reverts the skip from #35753. webpack 5.107.1 (published 2026-05-21) re-exports `lib/ModuleNotFoundError` as a backward-compat shim, restoring the deep-import path that `@module-federation/enhanced` relies on. All 21 webpack/lib/* paths needed by @module-federation/enhanced 2.4.0 / 2.5.0 now resolve. Refs: - webpack/webpack#20988 (shim, merged) - webpack/webpack#20989 (5.107.1 release, merged)
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 83c8214
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
May 21, 2026
FrozenPandaz
added a commit
that referenced
this pull request
May 22, 2026
…bpack 5.107.1 fix is live) (#35764) ## Current Behavior PR #35753 skipped 9 webpack-based React Module Federation e2e suites because webpack 5.107.0 (published 2026-05-20) reorganized its `lib/` directory and removed `lib/ModuleNotFoundError.js`, which `@module-federation/enhanced` deep-imports. Every webpack-based MF build/serve in the affected suites was failing with `Cannot find module 'webpack/lib/ModuleNotFoundError'`. ## Expected Behavior webpack 5.107.1 (published 2026-05-21) restored the path as a backward-compat shim — `lib/ModuleNotFoundError.js` now re-exports from `./errors/ModuleNotFoundError`. Verified locally that all 21 `webpack/lib/*` paths used by `@module-federation/enhanced` 2.4.0 / 2.5.0 now resolve in 5.107.1. This PR removes the `describe.skip` + TODO + `// eslint-disable-next-line jest/no-disabled-tests` lines from the 9 affected files, re-enabling: - `e2e/react/src/module-federation/core-webpack-basic-host-remote-generation.test.ts` - `e2e/react/src/module-federation/core-webpack-basic-playwright.test.ts` - `e2e/react/src/module-federation/core-webpack-name-and-root.test.ts` - `e2e/react/src/module-federation/core-webpack-query-params.test.ts` - `e2e/react/src/module-federation/core-webpack-ssr.test.ts` - `e2e/react/src/module-federation/dynamic-federation.webpack.test.ts` - `e2e/react/src/module-federation/federate-module.webpack.test.ts` - `e2e/react/src/module-federation/independent-deployability.webpack.test.ts` - `e2e/react/src/module-federation/misc-rspack-interoperability.test.ts` ## Related Issue(s) Reverts the skip from #35753. Upstream: - webpack/webpack#20988 (compat shim, merged) - webpack/webpack#20989 (webpack 5.107.1 release, merged) (cherry picked from commit b6858ba)
4 tasks
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
PR #35753 skipped 9 webpack-based React Module Federation e2e suites because webpack 5.107.0 (published 2026-05-20) reorganized its
lib/directory and removedlib/ModuleNotFoundError.js, which@module-federation/enhanceddeep-imports. Every webpack-based MF build/serve in the affected suites was failing withCannot find module 'webpack/lib/ModuleNotFoundError'.Expected Behavior
webpack 5.107.1 (published 2026-05-21) restored the path as a backward-compat shim —
lib/ModuleNotFoundError.jsnow re-exports from./errors/ModuleNotFoundError. Verified locally that all 21webpack/lib/*paths used by@module-federation/enhanced2.4.0 / 2.5.0 now resolve in 5.107.1.This PR removes the
describe.skip+ TODO +// eslint-disable-next-line jest/no-disabled-testslines from the 9 affected files, re-enabling:e2e/react/src/module-federation/core-webpack-basic-host-remote-generation.test.tse2e/react/src/module-federation/core-webpack-basic-playwright.test.tse2e/react/src/module-federation/core-webpack-name-and-root.test.tse2e/react/src/module-federation/core-webpack-query-params.test.tse2e/react/src/module-federation/core-webpack-ssr.test.tse2e/react/src/module-federation/dynamic-federation.webpack.test.tse2e/react/src/module-federation/federate-module.webpack.test.tse2e/react/src/module-federation/independent-deployability.webpack.test.tse2e/react/src/module-federation/misc-rspack-interoperability.test.tsRelated Issue(s)
Reverts the skip from #35753. Upstream:
ModuleNotFoundErrorfromlib/ModuleNotFoundErrorwebpack/webpack#20988 (compat shim, merged)