chore(repo): skip react-router typecheck e2e test due to vite version conflict#35110
Merged
Conversation
… conflict @react-router/dev does not yet support Vite 8, but pnpm can resolve both vite 7 and 8 in CI, causing typecheck failures from incompatible plugin types.
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 553ca4a
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Apr 1, 2026
vsavkin
pushed a commit
that referenced
this pull request
Apr 1, 2026
… conflict (#35110) ## Current Behavior The react-router typecheck e2e test fails in CI because pnpm resolves both vite 7 and vite 8 in the generated project. `@react-router/dev` picks up vite 8 plugin types while `defineConfig` uses vite 7 types, causing a TypeScript incompatibility. ## Expected Behavior The test is skipped until `@react-router/dev` adds Vite 8 support, at which point the `useViteV7` workaround and this skip can both be removed. ## Related Issue(s) Follow-up to #35101
FrozenPandaz
added a commit
that referenced
this pull request
Apr 1, 2026
… conflict (#35110) ## Current Behavior The react-router typecheck e2e test fails in CI because pnpm resolves both vite 7 and vite 8 in the generated project. `@react-router/dev` picks up vite 8 plugin types while `defineConfig` uses vite 7 types, causing a TypeScript incompatibility. ## Expected Behavior The test is skipped until `@react-router/dev` adds Vite 8 support, at which point the `useViteV7` workaround and this skip can both be removed. ## Related Issue(s) Follow-up to #35101 (cherry picked from commit 6962a3d)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The react-router typecheck e2e test fails in CI because pnpm resolves both vite 7 and vite 8 in the generated project.
@react-router/devpicks up vite 8 plugin types whiledefineConfiguses vite 7 types, causing a TypeScript incompatibility.Expected Behavior
The test is skipped until
@react-router/devadds Vite 8 support, at which point theuseViteV7workaround and this skip can both be removed.Related Issue(s)
Follow-up to #35101