Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 11cd538
☁️ Nx Cloud last updated this comment at |
…orkspace
## Current Behavior
When `--bundler=vite` is passed with an Angular preset, yargs accepts
it since `--bundler` is a shared string option. The invalid value flows
through to the preset generator which rejects it after a full pnpm
install, wasting ~25s of the user's time.
## Expected Behavior
Validate the bundler early in `determineAngularOptions` before any
install starts. Throws `CnwError('INVALID_BUNDLER')` so the error is
properly recorded via `recordStat` and surfaced as NDJSON for AI agents.
## Related Issue(s)
Fixes NXC-4166
leosvelperez
approved these changes
Mar 30, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 31, 2026
…orkspace (#35074) ## Current Behavior When `--bundler=vite` is passed with an Angular preset (`angular-monorepo` or `angular-standalone`), yargs accepts it since `--bundler` is a shared `type: 'string'` option with no per-stack `choices` constraint. The invalid value flows through to the preset generator which rejects it after a full pnpm install (~25s), wasting the user's time. ## Expected Behavior Validate the bundler early in `determineAngularOptions` before any install starts. Invalid bundlers throw `CnwError('INVALID_BUNDLER')` so the error is: - Properly recorded via `recordStat` for telemetry - Surfaced as NDJSON for AI agents - Shown as a clear `output.error()` for interactive users Valid Angular bundlers: `esbuild`, `rspack`, `webpack`. ## Related Issue(s) Fixes NXC-4166 (cherry picked from commit a309e31)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When
--bundler=viteis passed with an Angular preset (angular-monorepoorangular-standalone), yargs accepts it since--bundleris a sharedtype: 'string'option with no per-stackchoicesconstraint. The invalid value flows through to the preset generator which rejects it after a full pnpm install (~25s), wasting the user's time.Expected Behavior
Validate the bundler early in
determineAngularOptionsbefore any install starts. Invalid bundlers throwCnwError('INVALID_BUNDLER')so the error is:recordStatfor telemetryoutput.error()for interactive usersValid Angular bundlers:
esbuild,rspack,webpack.Related Issue(s)
Fixes NXC-4166