Merged
Conversation
wraithgar
reviewed
Apr 3, 2023
Member
|
|
3479114 to
ddb5e82
Compare
wraithgar
reviewed
Apr 3, 2023
wraithgar
reviewed
Apr 3, 2023
Member
|
Reading the readme again we do not make any guarantees about the order that the algorithms will be in |
ddb5e82 to
44078c0
Compare
wraithgar
approved these changes
Apr 3, 2023
Merged
4 tasks
2 tasks
H4ad
added a commit
to h4ad-forks/ssri
that referenced
this pull request
Dec 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance before:
After:
benchmark.js
When parsing is
strict, I introduce a small break change because I know the possible hashes, so I call it directly.Instead of the toString being stringified in the order in which the hashes were added, it will always be stringified in this order: sha512, sha384 and sha256.
If you think that is problematic, we can keep the loop, even if is a little bit slower.
References
Related to #71