[fix] node v10.0 lacks fs.promises
#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like these tests will fail until npm/node-gyp#5 lands and is released (and possibly updated here). |
Contributor
Author
|
Tests are now passing here, so this can be merged and released as well :-D |
ruyadorno
approved these changes
Feb 10, 2021
In this node version, fall back to `util.promisify` of the callback version. Maybe fixes npm/cli#2623. Maybe fixes npm/cli#2652. Maybe fixes npm/cli#2625. PR-URL: #21 Credit: @ljharb Close: #21 Reviewed-by: @ruyadorno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this node version, fall back to
util.promisifyof the callback version.Maybe fixes npm/cli#2623. Maybe fixes npm/cli#2652. Maybe fixes npm/cli#2625.
Updated the tests to run on the
.0s as well.