Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: npm/run-script
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.0.2
Choose a base ref
...
head repository: npm/run-script
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.0.3
Choose a head ref
  • 6 commits
  • 18 files changed
  • 4 contributors

Commits on Dec 4, 2023

  1. chore: bump @npmcli/template-oss from 4.19.0 to 4.21.1

    Bumps [@npmcli/template-oss](https://github.com/npm/template-oss) from 4.19.0 to 4.21.1.
    - [Release notes](https://github.com/npm/template-oss/releases)
    - [Changelog](https://github.com/npm/template-oss/blob/main/CHANGELOG.md)
    - [Commits](npm/template-oss@v4.19.0...v4.21.1)
    
    ---
    updated-dependencies:
    - dependency-name: @npmcli/template-oss
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and lukekarrys committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1f5fd9a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    92c4354 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. chore: bump @npmcli/template-oss from 4.21.1 to 4.21.3

    Bumps [@npmcli/template-oss](https://github.com/npm/template-oss) from 4.21.1 to 4.21.3.
    - [Release notes](https://github.com/npm/template-oss/releases)
    - [Changelog](https://github.com/npm/template-oss/blob/main/CHANGELOG.md)
    - [Commits](npm/template-oss@v4.21.1...v4.21.3)
    
    ---
    updated-dependencies:
    - dependency-name: @npmcli/template-oss
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and lukekarrys committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    ccf6eb6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a0443b View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. fix: Revert Signal Handling Regression (#188)

    This PR reverts the changes made in commit
    `545f3be94d412941537ad0011717933d48cb58cf`, which inadvertently broke
    signal forwarding to child processes (PR #142 ).
    Contrary to the assumptions by @nlf , `SIGTERM` and similar signals are
    not being correctly propagated to child processes. Instead, they are
    only received by npm, resulting in incomplete signal handling.
    
    The removal of signal forwarding in #142 means that child processes do
    not receive necessary signals for appropriate cleanup and termination.
    
    This issue is evident in workflows involving `npm start` used as a
    Docker command for local execution. For instance, using CTRL + C does
    not properly terminate the application
    and results in a forced kill after a 10-second delay.
    
    This behavior could lead to more significant problems in production
    environments, (if `npm` is used to start the app) such as data loss due
    to improper database connection closures.
    
    Create a package.json with the following content:
    ```json
    {
      "name": "npm",
      "scripts": {
        "start": "node ./main-test.js"
      }
    }
    ```
    
    Create a main-test.js file:
    ```typescript
    const interval = setInterval(() => console.log('alive!'), 3000);
    
    async function onSignal(signal) {
      console.log(`${signal} received, cleaning up...`);
      clearInterval(interval);
      console.log('Cleaning up done');
    }
    process.on('SIGINT', onSignal);
    process.on('SIGTERM', onSignal);
    ```
    
    Execute `npm start`. The script should output `alive!` every 3 seconds.
    Attempt to terminate it using `kill -SIGTERM [PID]`.
    It should log `Cleaning up done` and shut down gracefully,
    which it does in older versions of `npm` (e.g., `v8.19.4`) but fails in
    newer versions (e.g., `v9.6.7`).
    
    Reverting this change will restore the expected behavior for signal
    handling in `npm`
    
    - npm/cli#6547
    - npm/cli#6684
    - #142
    wiktor-obrebski authored and wraithgar committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    089eefb View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. chore: release 7.0.3 (#186)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ## [7.0.3](v7.0.2...v7.0.3)
    (2024-01-03)
    
    ### Bug Fixes
    
    *
    [`089eefb`](089eefb)
    Revert Signal Handling Regression (#188) (@wiktor-obrebski)
    
    ### Chores
    
    *
    [`8a0443b`](8a0443b)
    [#187](#187) postinstall for
    dependabot template-oss PR (@lukekarrys)
    *
    [`ccf6eb6`](ccf6eb6)
    [#187](#187) bump
    @npmcli/template-oss from 4.21.1 to 4.21.3 (@dependabot[bot])
    *
    [`92c4354`](92c4354)
    [#184](#184) postinstall for
    dependabot template-oss PR (@lukekarrys)
    *
    [`1f5fd9a`](1f5fd9a)
    [#184](#184) bump
    @npmcli/template-oss from 4.19.0 to 4.21.1 (@dependabot[bot])
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    802dec9 View commit details
    Browse the repository at this point in the history
Loading