Merged
Conversation
BREAKING CHANGE: this package is now compatible with the following semver range for node: `^14.17.0 || ^16.13.0 || >=18.0.0`
cefa899 to
7dd1acb
Compare
Comment on lines
+3
to
+5
| const esc = (str) => str | ||
| .replace(/\(/g, '\\(') | ||
| .replace(/\)/g, '\\)') |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
Comment on lines
+3
to
+4
| const esc = (str) => str | ||
| .replace(/\(/g, '\\(') |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
wraithgar
reviewed
Dec 12, 2022
lukekarrys
commented
Dec 12, 2022
d03696f to
7aa3dc3
Compare
BREAKING CHANGE: this module has been refactored to use promises - the API is now promise only and no longer accepts a callback - the Promise is resolved to a string and no longer returns `isDefault`
7aa3dc3 to
b3b8f19
Compare
nlf
approved these changes
Dec 13, 2022
marmitar
added a commit
to marmitar/thelounge
that referenced
this pull request
Nov 4, 2025
Important changes (npm/read#77): - exported as ESM - includes type definitions - no callback API (npm/read#40) It was possible to recreate the callback API using `Promise.then`, but it's not really worth it in this case.
marmitar
added a commit
to marmitar/thelounge
that referenced
this pull request
Nov 17, 2025
Important changes (npm/read#77): - exported as ESM - includes type definitions - no callback API (npm/read#40) It was possible to recreate the callback API using `Promise.then`, but it's not really worth it in this case.
marmitar
added a commit
to marmitar/thelounge
that referenced
this pull request
Jan 31, 2026
Important changes (npm/read#77): - exported as ESM - includes type definitions - no callback API (npm/read#40) It was possible to recreate the callback API using `Promise.then`, but it's not really worth it in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31