Merged
Conversation
Member
|
What happens w/ this PR if the user has not set |
wraithgar
reviewed
Oct 17, 2024
Contributor
Author
wraithgar
approved these changes
Oct 18, 2024
Merged
wraithgar
pushed a commit
that referenced
this pull request
Oct 18, 2024
🤖 I have created a release *beep* *boop* --- ## [8.0.2](v8.0.1...v8.0.2) (2024-10-18) ### Bug Fixes * [`5ecf301`](5ecf301) [#128](#128) open URL in browser on WSL (#128) (@mbtools, @wraithgar) ### Chores * [`ef4ba09`](ef4ba09) [#127](#127) bump @npmcli/template-oss from 4.23.3 to 4.23.4 (#127) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Here's a more elegant solution for opening URLs from WSL in your favorite browser. It is based on
sensible-browserwhich is included in the default distribution for WSL. This avoids issues with the WSL environment,cmd.exe. quoting parameters, etc.In WSL, set the default browser using the
BROWSERvariable, for example,Note: To permanently set the default browser, add the appropriate entry to your shell's RC file, e.g. .bashrc or .zshrc.
To launch a URL from the WSL command line:
To launch a URL using
promise-spawn:Replaces #118
Closes #62
Test