Skip to content

Prevent null TypeError using Pacote.tarball.file() as root on unix machines #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isaacs merged 1 commit into from
Jan 7, 2021
Merged

Prevent null TypeError using Pacote.tarball.file() as root on unix machines #56

isaacs merged 1 commit into from
Jan 7, 2021

Conversation

@burkedavison
Copy link

@burkedavison burkedavison commented Dec 30, 2020 •
edited
Loading

What / Why
I am getting this error on my Jenkins docker build:

TypeError: Cannot read property 'then' of null
  at /home/jenkins/agent/workspace/<project>/node_modules/pacote/lib/fetcher.js:355:13

This is because the return value of this[_chown] is null, and not a Promise as the tarballFile() logic assumes.

  [_chown] (path, uid, gid) {
    return selfOwner && (selfOwner.gid !== gid || selfOwner.uid !== uid)
      ? chownr(path, uid, gid)
      : /* istanbul ignore next - we don't test in root-owned folders */ null
  }

This PR attempts to simply add a null check and otherwise maintain behavior. I've tested this issue with an internal build, and verified it resolves the issue.

isaacs
isaacs approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extremely minor nit which I'm happy to fix up on your behalf. Good catch, this is clearly correct! Will get landed asap.

@isaacs isaacs force-pushed the bugfix/tarball-file-null-error-unix-root branch from c57035c to 5d74552 Compare January 7, 2021 19:27
@isaacs isaacs merged commit 5d74552 into npm:latest Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@isaacs isaacs isaacs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@burkedavison @isaacs