Conversation
…path components When a custom registry URL includes a path (e.g. https://example.com/javascript), the attestation URL was incorrectly constructed by concatenating the full registry URL with the full pathname from the attestation URL, causing the path to be duplicated (e.g. /javascript/javascript/-/npm/v1/attestations/...). Use the URL constructor to correctly resolve the pathname against the registry origin, matching the existing pattern in lib/remote.js.
wraithgar
approved these changes
Feb 24, 2026
Merged
wraithgar
pushed a commit
that referenced
this pull request
Feb 24, 2026
🤖 I have created a release *beep* *boop* --- ## [21.4.0](v21.3.1...v21.4.0) (2026-02-24) ### Features * [`6912f24`](6912f24) [#451](#451) add allowRegistry option (#451) (@wraithgar) ### Bug Fixes * [`ab37bc1`](ab37bc1) [#452](#452) prevent path duplication in attestation URL for registries with … (#452) (@ajayk) * [`ab37bc1`](ab37bc1) [#452](#452) prevent path duplication in attestation URL for registries with (@ajayk) * [`8b8ea3b`](8b8ea3b) [#454](#454) skip registry key check for keyless (Sigstore/Fulcio) attestations (#454) (@ajayk) * [`8b8ea3b`](8b8ea3b) [#454](#454) skip registry key check for keyless (Sigstore/Fulcio) attestations (@ajayk) ### Chores * [`0dfd1cd`](0dfd1cd) [#456](#456) remove git config from tests (#456) (@wraithgar) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wraithgar
pushed a commit
to npm/cli
that referenced
this pull request
Feb 24, 2026
npm audit signatures fails when a registry only uses keyless (Sigstore/Fulcio) attestations and doesn't provide registry signing keys. The[ auditedWithKeysCount guard in verify-signatures.js ](https://github.com/npm/cli/blob/latest/lib/utils/verify-signatures.js#L48) treats any registry without keys as unsupported, even though keyless attestations don't need registry keys at all -- the signing certificate is embedded directly in the bundle and verified through Sigstore's TUF root of trust. This updates the check to also accept verified keyless attestations as a valid audit result, so registries that exclusively use Fulcio-based signing (like Chainguard) work correctly with npm audit signatures. Before this change: npm error found no dependencies to audit that were installed from a supported registry After: audited 1 package in 1s 1 package has a verified attestation This change works together with the corresponding pacote fixes ([pacote/pull/454](npm/pacote#454)) ([pacote/pull/452](npm/pacote#452)) which allows keyless attestation bundles to pass the registry key matching check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: prevent path duplication in attestation URL for registries with path components
When a custom registry URL includes a path (e.g. https://example.com/javascript),
the attestation URL was incorrectly constructed by concatenating the full registry
URL with the full pathname from the attestation URL, causing the path to be
duplicated (e.g. /javascript/javascript/-/npm/v1/attestations/...).
Use the URL constructor to correctly resolve the pathname against the registry
origin, matching the existing pattern in lib/remote.js.
References
Fixes #450