Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: npm/normalize-package-data
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.0.1
Choose a base ref
...
head repository: npm/normalize-package-data
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.0.2
Choose a head ref
  • 2 commits
  • 4 files changed
  • 3 contributors

Commits on Jun 25, 2024

  1. deps: replace is-core-module with node builtin (#224) 

    <!-- What / Why -->
<!-- Describe the request in detail. What it does and why it's being
changed. -->
This PR replaces usage of `is-core-module` with node's built-in
`module.builtinModules`, which was added in node 9.3.0, 8.10.0, and
6.13.0. My plan was to use `module.isBuiltin` but that would be a
breaking change as it got added in node 16.17.0 and 18.6.0. Maybe once
older node versions get dropped :P. This makes `normalize-package-data`
use 3 less dependencies, bringing down the total count to 8. The only
difference this *could* have is that `builtinModules` do not include
`node:` builtins, but it doesn't affect this library as names prefixed
by `node:` already throw as they are not valid names.

Packages such as `is-core-module`'s dependencies are only there for
support with *ancient* node versions (>=0.4) and as such have *many*
polyfills, including one that literally emulates hasOwnProperty, and
overall end up cluttering the whole javascript ecosystem. Since this
package includes an engines field of `^16.14.0 || >=18.0.0`, there's no
real reason in using it over a built-in. `is-core-module` in particular
does have its own use case (checking the list of built-ins of a certain
node version other than the current one), but its use in this library
can be replicated by `module.builtinModules`

## References
https://nodejs.org/api/module.html#modulebuiltinmodules

<!-- Examples:
  Related to #0
  Depends on #0
  Blocked by #0
  Fixes #0
  Closes #0
-->

---------

Co-authored-by: Gar <wraithgar@github.com>
    @SuperchupuDev @wraithgar
    SuperchupuDev and wraithgar authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    43bab20 View commit details
    Browse the repository at this point in the history

  2. chore: release 6.0.2 (#226) 

    🤖 I have created a release *beep* *boop*
---


##
[6.0.2](v6.0.1...v6.0.2)
(2024-06-25)

### Dependencies

*
[`43bab20`](43bab20)
[#224](#224) replace
`is-core-module` with node builtin (#224) (@SuperchupuDev, @wraithgar)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @github-actions
    github-actions[bot] authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    80957f1 View commit details
    Browse the repository at this point in the history
Loading