Merged
Conversation
This was referenced Nov 22, 2024
Contributor
Author
|
failing because I added package-json 6.1.0 manually waiting for npm/package-json#134 |
Member
It only affects manually entered things, which usually isn't something we include in the semver contract. Only programmatic things. If someone were already using this programmatically would things not work where they did before? |
Contributor
Author
|
@wraithgar nope I don't think so, at least not though intended means |
Member
|
I don't think it is then. We'll be bumping engines here so we are gonna be doing a semver major anyways. We can change the first commit to a normal |
wraithgar
approved these changes
Dec 2, 2024
Merged
wraithgar
pushed a commit
that referenced
this pull request
Dec 2, 2024
🤖 I have created a release *beep* *boop* --- ## [8.0.0](v7.0.2...v8.0.0) (2024-12-02) ###⚠️ BREAKING CHANGES * this module is now compatible with the following node versions: ^20.17.0 || >=22.9.0 * adds a new `type` prompt and changes the sort order of created packages ### Features * [`5eeea50`](5eeea50) [#313](#313) adds type, sorting (#313) (@reggi) ### Bug Fixes * [`f4c1430`](f4c1430) update node engines to ^20.17.0 || >=22.9.0 (#318) (@wraithgar) ### Chores * [`47339ef`](47339ef) [#311](#311) bump @npmcli/config from 8.3.4 to 9.0.0 (#311) (@dependabot[bot]) * [`2ccbf30`](2ccbf30) [#310](#310) bump @npmcli/template-oss from 4.23.3 to 4.23.4 (#310) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
typetopackage.jsonfor use when runningnpm init.commonjscommonjs|modulenpm init --init-type module -yinit.type=modulein.npmrcon the shoulders of #302
a part of the npm 11 roadmap npm/statusboard#898
statusboard issue here npm/statusboard#654
older rfc npm/rfcs#347