fix: ignore packageLockOnly in npx/exec #4649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
no statistically significant performance changes detected timing results
|
lukekarrys
suggested changes
Apr 13, 2022
| ...flatOptions | ||
| } = opts | ||
| delete flatOptions.packageLock | ||
| delete flatOptions.packageLockOnly |
Contributor
There was a problem hiding this comment.
We shouldn't delete things from flatOptions since we pass it everywhere and it could have unintended side effects. I think creating a new object and omitting these specifically is a better option.
Member
There was a problem hiding this comment.
This should happen in the command itself too.
Contributor
|
replaced by #4843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When npx/exec is ran as a script, packageLock and packageLockOnly config items can be passed to npx, which may prevent the bin packages from being installed.
This updated libnpmexec to clear those config items.
Closes #4595