Conversation
wraithgar
reviewed
Jan 3, 2024
| // Set all this up to run on the stream and then just return the stream | ||
| Promise.resolve().then(async () => { | ||
| const { stat, cpath, sri } = await withContentSri(cache, integrity, async (cpath, sri) => { | ||
| // just stat to ensure it exists |
Member
There was a problem hiding this comment.
Yeah this comment should have been a code smell. It's right in the docs for fs.stat
Using fs.stat() to check for the existence of a file before calling fs.open(), fs.readFile(), or fs.writeFile() is not recommended. Instead, user code should open/read/write the file directly and handle the error raised if the file is not available.
wraithgar
approved these changes
Jan 3, 2024
Merged
wraithgar
pushed a commit
that referenced
this pull request
Jan 4, 2024
🤖 I have created a release *beep* *boop* --- ## [18.0.2](v18.0.1...v18.0.2) (2024-01-03) ### Bug Fixes * [`b9f488d`](b9f488d) [#255](#255) Speed up cache reads (#255) (@thecodrr) ### Chores * [`7eab139`](7eab139) [#252](#252) postinstall for dependabot template-oss PR (@lukekarrys) * [`44bedb2`](44bedb2) [#252](#252) bump @npmcli/template-oss from 4.21.1 to 4.21.3 (@dependabot[bot]) * [`a12bdf3`](a12bdf3) [#248](#248) postinstall for dependabot template-oss PR (@lukekarrys) * [`62e5a94`](62e5a94) [#248](#248) bump @npmcli/template-oss from 4.19.0 to 4.21.1 (@dependabot[bot]) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR speeds up
read.streamandreadby skippingfs.statcall ifsizewas passed viaopts. Currently, the only reason for doing astatcall is to get the size (and throw the size mismatch error if the size is different). This is unnecessary for 3 reasons:read.stream, the stream already compares the sizes at the end and throws an error if there's a mismatch.read, we can compare the sizes after reading the cache contentsIn this PR, the
statcall is only made if the user does not pass asizeproperty viaopts. This makes sense because without knowing thesize, the stream has to make an unnecessaryfs.readcall at the end before closing which has a significant cost (that cost is much, much greater than the cost of doingfs.stat).On my machine, the benchmarks with this change look like this:
That's a solid 16% improvement in the case of
read.streamand 36% improvement in the case ofread.References