Skip to content

fixes ConnectionReset on secured connection on Windows#6287

Merged
vonzshik merged 1 commit intonpgsql:mainfrom
trivalik:fixSsl
Nov 5, 2025
Merged

fixes ConnectionReset on secured connection on Windows#6287
vonzshik merged 1 commit intonpgsql:mainfrom
trivalik:fixSsl

Conversation

@trivalik
Copy link
Contributor

@trivalik trivalik commented Nov 3, 2025

fixes #6274

@roji
Copy link
Member

roji commented Nov 3, 2025 •
edited
Loading

@trivalik this PR seems to be mis-targeted - I assume you wanted to target branch release/8.0.9 (the last version to support .NET Framework). If so, please retarget this PR (edit button).

@trivalik trivalik changed the base branch from main to hotfix/8.0.9 November 3, 2025 12:28
@trivalik
Copy link
Contributor Author

trivalik commented Nov 3, 2025

BTW an appended SSL Mode=Allow had no effect, so not handled.

@vonzshik
Copy link
Contributor

vonzshik commented Nov 3, 2025

Instead of doing a workaround .NET Framework, the more correct fix is to not check for PostgresException and instead always retry if it's Prefer or Allow. In addition, this has to be merged first into the main branch and then backported to 9 and 8.

@trivalik trivalik changed the base branch from hotfix/8.0.9 to main November 3, 2025 20:35
roji
roji reviewed Nov 3, 2025
View reviewed changes
roji
roji reviewed Nov 4, 2025
View reviewed changes
@trivalik trivalik changed the title fixes first ConnectionReset for .NET Framework on secured connection fixes ConnectionReset for .NET Framework on secured connection Nov 4, 2025
@trivalik trivalik changed the title fixes ConnectionReset for .NET Framework on secured connection fixes ConnectionReset on secured connection on Windows Nov 4, 2025
roji
roji reviewed Nov 4, 2025
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vonzshik leaving to you to review/approve this as you know all this best.

vonzshik
vonzshik reviewed Nov 4, 2025
View reviewed changes
@vonzshik vonzshik enabled auto-merge (squash) November 5, 2025 14:05
@vonzshik vonzshik merged commit ed512e5 into npgsql:main Nov 5, 2025
13 checks passed
vonzshik pushed a commit that referenced this pull request Nov 5, 2025
@trivalik @vonzshik
handles SSL ConnectionReset on Windows; fixes #6274 (#6287)
04304d6 
Fixes #6274

(cherry picked from commit ed512e5)
vonzshik pushed a commit that referenced this pull request Nov 5, 2025
@trivalik @vonzshik
handles SSL ConnectionReset on Windows; fixes #6274 (#6287)
a5bede5 
Fixes #6274

(cherry picked from commit ed512e5)
@vonzshik
Copy link
Contributor

vonzshik commented Nov 5, 2025

Backported to 9.0.5 via 04304d6, 8.0.9 via a5bede5

@trivalik trivalik mentioned this pull request Nov 5, 2025
Closed
@trivalik

This comment was marked as resolved.

Sign in to view
@roji

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roji roji roji left review comments

@vonzshik vonzshik vonzshik approved these changes

@Brar Brar Awaiting requested review from Brar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.NET Framework broken in 8.0.8 for first connect

3 participants

@trivalik @roji @vonzshik