Fix nre while cancelling PrepareAsync via cancellation token#4559
Merged
Fix nre while cancelling PrepareAsync via cancellation token#4559
Conversation
roji
approved these changes
Aug 3, 2022
test/Npgsql.Tests/PrepareTests.cs
Outdated
| } | ||
| catch (OperationCanceledException) | ||
| { | ||
| // expected exception |
Contributor
Author
There was a problem hiding this comment.
Not really. The cancellation can happen before we check the token (in which case, OCE is thrown), or after (no exception).
Contributor
Author
|
Backported to 6.0.6 via 40664dc. |
|
@vonzshik Will this be backported to major version 5 as well? |
Member
|
@Bartleby2718 that's unlikely, we generally follow the .NET support lifetimes, and like .NET 5.0, it's out of support; this is also far from being a critical bug justifying a backport, it seems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4209