Firing state change event immediately on property change#3451
Merged
YohDeadfall merged 7 commits intonpgsql:mainfrom Jan 14, 2021
YohDeadfall:fixed-connection-state-event
Merged
Firing state change event immediately on property change#3451YohDeadfall merged 7 commits intonpgsql:mainfrom YohDeadfall:fixed-connection-state-event
YohDeadfall merged 7 commits intonpgsql:mainfrom
YohDeadfall:fixed-connection-state-event
Conversation
roji
reviewed
Jan 12, 2021
| //[Timeout(5000)] | ||
| public async Task BrokenLifecycle() | ||
| { | ||
| if (IsMultiplexing) |
Member
There was a problem hiding this comment.
I think this test should pass with multiplexing too, no? You probably need to make sure the connection is bound before getting its PID, that can be done simply by starting a transaction.
Contributor
Author
There was a problem hiding this comment.
You made me to find another bug :(
Member
|
@YohDeadfall looks like we all like what you're doing :) Take a look at my comments above. |
Contributor
Author
|
Backported to 5.0.4 via 8fe0cb0. |
Member
|
:( I always backport immediately because I know I'll forget... |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3442