Skip to content

Bug fix in NpgsqlQuerySqlGenerator with PgFunctionExpression#425

Merged
roji merged 1 commit intonpgsql:devfrom
austindrenski:pgfunction-patch
May 25, 2018
Merged

Bug fix in NpgsqlQuerySqlGenerator with PgFunctionExpression#425
roji merged 1 commit intonpgsql:devfrom
austindrenski:pgfunction-patch

Conversation

@austindrenski
Copy link
Contributor

@austindrenski austindrenski commented May 25, 2018

Bug

PgFunction("abbrev", typeof(string), new [] { inetExpression }) 
// where inetExpression is something like x => x.Inet
-- before:
SELECT abbrev(x."Inet", );

-- after:
SELECT abbrev(x."Inet");

Other

Also includes general cleanup to match project style, remove unused using-statements, etc.

@austindrenski
Fixes a bug in NpgsqlQuerySqlGenerator with PgFunctionExpression
8df97a5 
- Bug:
  - Input:  PgFunction("abbrev", typeof(string), new [] { inetExpression }) // x.Inet
  - Before: abbrev("x"."Inet",)
  - After:  abbrev("x"."Inet")

- Also includes general cleanup to match project style, remove unused using-statements, etc.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request May 25, 2018
@austindrenski
Adds network address (cidr and inet) functions for translation
126c4b0 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
@austindrenski austindrenski mentioned this pull request May 25, 2018
Merged
@roji roji merged commit c1abc10 into npgsql:dev May 25, 2018
@roji
Copy link
Member

roji commented May 25, 2018

Thanks! That was quite a silly bug on my part...

@austindrenski austindrenski deleted the pgfunction-patch branch May 25, 2018 16:44
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request May 25, 2018
@austindrenski
Adds network address (cidr and inet) functions for translation
e8ac7cf 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request May 26, 2018
@austindrenski
Adds network address (cidr and inet) functions for translation
b860f0a 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request May 27, 2018
@austindrenski
Adds network address (cidr and inet) functions for translation
10c6974 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request May 29, 2018
@austindrenski
Adds network address (cidr and inet) functions for translation
7cb8f70 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request May 29, 2018
@austindrenski
Adds network address function translations
669a2d8 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request May 31, 2018
@austindrenski
Adds network address function translations
0224b44 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request Jun 3, 2018
@austindrenski
Adds network address function translations
9068a41 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request Jul 15, 2018
@austindrenski
Add network address function translations
c7aa01c 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request Jul 21, 2018
@austindrenski
Add network address function translations
63d627b 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request Jul 22, 2018
@austindrenski
Add network address function translations
25b747e 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
austindrenski added a commit to austindrenski/npgsql-efcore.pg that referenced this pull request Jul 22, 2018
@austindrenski
Add network address function translations
0f07229 
- Maps cidr and inet functions to CLR extension methods.
  - See: https://www.postgresql.org/docs/current/static/functions-net.html#CIDR-INET-FUNCTIONS-TABLE

- Includes functional tests covering translation.

- Includes the bug fix in npgsql#425.
  - This can be removed once npgsql#425 is merged.
@austindrenski austindrenski self-assigned this Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@austindrenski austindrenski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@austindrenski @roji