Skip to content
This repository was archived by the owner on Jun 28, 2021. It is now read-only.

targets.rake: raise if sshpass return error#6

Merged
notro merged 2 commits intonotro:masterfrom
pietrushnic:sshpass_wa
Oct 3, 2014
Merged

targets.rake: raise if sshpass return error#6
notro merged 2 commits intonotro:masterfrom
pietrushnic:sshpass_wa

Conversation

@pietrushnic
Copy link
Contributor

Fixes #5
I'm not sure if exit or raise should be used. I omitted rasing exception after running rpi-update on target, because it can fail from different reasons then connectivity issues.

@notro
Copy link
Owner

notro commented Oct 2, 2014

I think it's better to do this check inside the ssh() function in utils.rb, instead of everywhere ssh() is used.

@pietrushnic
Copy link
Contributor Author

Ok, I will improve this PR according to your suggestions.

@pietrushnic
Copy link
Contributor Author

Le me know if this version is ok.

notro added a commit that referenced this pull request Oct 3, 2014
targets.rake: raise if sshpass return error
@notro notro merged commit bfbcb8d into notro:master Oct 3, 2014
@notro
Copy link
Owner

notro commented Oct 3, 2014

Thanks

@pietrushnic pietrushnic deleted the sshpass_wa branch October 6, 2014 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rpi-build doesn't return error when invalid SHIP address given

2 participants