Skip to content

reintroduce pollwatcher now that rust 1.1 is out#19

Merged
passcod merged 1 commit into
notify-rs:masterfrom
blaenk:reintroduce-poll
Jun 26, 2015
Merged

reintroduce pollwatcher now that rust 1.1 is out#19
passcod merged 1 commit into
notify-rs:masterfrom
blaenk:reintroduce-poll

Conversation

@blaenk

@blaenk blaenk commented Jun 25, 2015

Copy link
Copy Markdown
Contributor

Closes #12

This uses @acrichto's filetime crate for modified time fetching.

@blaenk

blaenk commented Jun 25, 2015

Copy link
Copy Markdown
Contributor Author

I'm not sure what @maurizi's status is on the windows watcher, that would be the preferred way, but I think a poll watcher is still good to have, if not just in the meantime, then as a reference implementation of sorts.

@maurizi

maurizi commented Jun 25, 2015

Copy link
Copy Markdown
Contributor

I'm working on the windows watcher, but it still has some kinks in it and life is interfering with me getting around to finishing it at the moment. I should be able to get back to it soon though.

A polling solution is a good idea anyway, for more esoteric platforms like BSD, or for cases where the the OS file watching APIs do not work properly, like when the watched directory is on a VirtualBox shared folder.

@blaenk

blaenk commented Jun 25, 2015

Copy link
Copy Markdown
Contributor Author

Awesome, I'm rooting for you @maurizi 👍

passcod
passcod reviewed Jun 26, 2015
View reviewed changes
Comment thread README.md

@passcod passcod Jun 26, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the notice at the top while we're at it?

@blaenk blaenk Jun 26, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do when I get back.

On Thursday, June 25, 2015, Félix Saparelli notifications@github.com
wrote:

In README.md
#19 (comment):

  • OS X: FSEvent
    +- All platforms: polling

Can you also remove the notice at the top while we're at it?

—
Reply to this email directly or view it on GitHub
https://github.com/passcod/rsnotify/pull/19/files#r33318762.

  • Jorge Israel Peña

@passcod

passcod commented Jun 26, 2015

Copy link
Copy Markdown
Member

Great job! Thank you so much.

I'll open a ticket for the various TODOs in the code.

@blaenk blaenk force-pushed the reintroduce-poll branch from e00de11 to dc21d62 Compare June 26, 2015 01:16
@blaenk

blaenk commented Jun 26, 2015

Copy link
Copy Markdown
Contributor Author

Alright I removed the notice.

@passcod

passcod commented Jun 26, 2015

Copy link
Copy Markdown
Member

Awesome!

passcod added a commit that referenced this pull request Jun 26, 2015
@passcod
Merge pull request #19 from blaenk/reintroduce-poll
78ea4f6 
Reintroduce PollWatcher

With hearty thanks to @blaenk 
Fixes #12
@passcod passcod merged commit 78ea4f6 into notify-rs:master Jun 26, 2015
@passcod

passcod commented Jun 26, 2015

Copy link
Copy Markdown
Member

I'll do a release later today with #14 and #18 also merged in.

@sapphi-red sapphi-red mentioned this pull request Jun 15, 2026
Merged
sapphi-red added a commit to rolldown/notify that referenced this pull request Jun 15, 2026
@sapphi-red
feat: store accurate mtime for polling (#101)
f4276d6 
It seems this `.seconds` was added when the polling watcher was added
(notify-rs#19). So I guess there wasn't
any huge reason for this.

refs rolldown/rolldown#9736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blaenk @maurizi @passcod