Skip to content

Update Dutch.xml for 7.9.3#9461

Closed
RockyTDR wants to merge 1 commit intonotepad-plus-plus:masterfrom
RockyTDR:Update-Dutch-Translations-7.9.3
Closed

Update Dutch.xml for 7.9.3#9461
RockyTDR wants to merge 1 commit intonotepad-plus-plus:masterfrom
RockyTDR:Update-Dutch-Translations-7.9.3

Conversation

@RockyTDR
Copy link
Copy Markdown
Contributor

@RockyTDR RockyTDR commented Jan 28, 2021

  • Add and translate missing strings for Notepad++ version 7.9.3 Dutch translation
  • synchronize lay-out of Dutch file with English source file to make future comparison easier
  • complete re-check of all translations

Replaces #9439 because something went wrong.

@RockyTDR
Update Dutch.xml for 7.9.3
936ea2d 
- Add and translate missing strings for Notepad++ version 7.9.3 Dutch translation
- synchronize lay-out of Dutch file with English source file to make future comparison easier
- complete re-check of all translations

Replaces #9439 because something went wrong.
@donho
Copy link
Copy Markdown
Member

donho commented Jan 28, 2021

@RockyTDR
The change of file content is too important in your PR:
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/9461/files

It should look like this one:
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/9462/files

Apparently you have changed indentation of whole file which is not accepted:

5. Make your modification compact - don't reformat source code in your request. It makes code review more difficult.
6. PR of reformatting (changing of ws/TAB, line endings or coding style) of source code won't be accepted. Use issue trackers for your request instead.
7. Typo fixing and code refactoring won't be accepted - please create issues with title started with TYPO to request the changing.

https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/CONTRIBUTING.md#guidelines-for-pull-requests

@donho donho closed this Jan 28, 2021
@donho donho added the reject label Jan 28, 2021
This was referenced Jan 28, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

reject

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RockyTDR @donho