Skip to content

Update dutch.xml (v7.9.2)#9439

Closed
RockyTDR wants to merge 3 commits intonotepad-plus-plus:masterfrom
RockyTDR:Dutch-translation-for-7.9.2
Closed

Update dutch.xml (v7.9.2)#9439
RockyTDR wants to merge 3 commits intonotepad-plus-plus:masterfrom
RockyTDR:Dutch-translation-for-7.9.2

Conversation

@RockyTDR
Copy link
Copy Markdown
Contributor

@RockyTDR RockyTDR commented Jan 22, 2021

Add and translate missing strings for Notepad++ version 7.9.2 Dutch translation

  • synchronize lay-out of Dutch file with English source file to make future comparison easier

@RockyTDR
Update dutch.xml
ec18def 
Add and translate missing strings for Notepad++ version 7.9.2 Dutch translation
@chcg chcg added the translation Issues or PRs related to translation of N++ UI label Jan 23, 2021
@donho
Copy link
Copy Markdown
Member

donho commented Jan 27, 2021

Please solve the conflict and check v7.9.3 translation diff comparing with v7.9.2. If nothing is missed, please confirm it with me, so I will include this PR in the next release. Thank you!

@donho donho self-assigned this Jan 27, 2021
@RockyTDR
Copy link
Copy Markdown
Contributor Author

RockyTDR commented Jan 27, 2021 •
edited
Loading

Please solve the conflict and check v7.9.3 translation diff comparing with v7.9.2. If nothing is missed, please confirm it with me, so I will include this PR in the next release. Thank you!

@donho The updated Dutch translations are based on the latest source English.xml, so they are already containing the missing strings from the translation diff for 7.9.3.
Sorry for the confusion!

I left one of the older strings because I was comparing between "English" and "English customizable".

@donho
Copy link
Copy Markdown
Member

donho commented Jan 27, 2021

@RockyTDR I just check your PR, there's a problem: all lines in dutch.xml are changed instead of only the necessary changes.
I have to reject this PR, because of the whole modification. Feel free to create a new PR, take the original file from the repository and modify only the lines which should change.

@donho donho closed this Jan 27, 2021
@donho donho added reject and removed suspended labels Jan 27, 2021
This was referenced Jan 28, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@donho donho

Labels

reject translation Issues or PRs related to translation of N++ UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RockyTDR @donho @chcg