Skip to content

Add 11 missing translatable items to original XML#542

Closed
batagy wants to merge 1 commit intonotepad-plus-plus:masterfrom
batagy:patch-3
Closed

Add 11 missing translatable items to original XML#542
batagy wants to merge 1 commit intonotepad-plus-plus:masterfrom
batagy:patch-3

Conversation

@batagy
Copy link
Copy Markdown
Contributor

@batagy batagy commented Jul 22, 2015

This is an attempt to add the complete, currently known unofficial strings to original english.xml language template. For version 6.8. Don Ho should review them, and make them official. 10 items are added, and 1 item is just uncommented. Translators used to use these items actually, unofficially, they are not present in original file.

@batagy
Add 11 missing translatable items to original XML
6a0f533 
This is an attempt to add the complete, currently known unofficial strings to original english.xml language template. For version 6.8. Don Ho should review them, and make them official. 10 items are added, and 1 item is just uncommented.
@milipili milipili added this to the 6.x milestone Jul 22, 2015
@milipili milipili added enhancement Proposed enhancements of existing features translation Issues or PRs related to translation of N++ UI labels Jul 22, 2015
@Rikk
Copy link
Copy Markdown
Contributor

Rikk commented Jul 22, 2015

So this is a rework fixing #511, ya? If so, then @milipili could close it.

@batagy
Copy link
Copy Markdown
Contributor Author

batagy commented Jul 23, 2015

Yes, it's a rework of #511.
#511 is faulty, incorrect. That one should be closed.

@bovirus
Copy link
Copy Markdown
Contributor

bovirus commented Jul 24, 2015

@milipili
The english.xml language is not updated.
Reported 16 days ago....
Could you please update with @batagy proposal? Thanks.

@milipili
Copy link
Copy Markdown
Contributor

milipili commented Jul 24, 2015

@donho will review this

@bovirus
Copy link
Copy Markdown
Contributor

bovirus commented Jul 24, 2015

@milipili
Thanks. I hope that could be update soon.

Which the right places to ask about a bug of the installer script?
From a long time in the installer the component selection, component description, and program options window are untranslated.
I posted it into Community but no one answer.

@donho
Copy link
Copy Markdown
Member

donho commented Jul 24, 2015

while @milipili is in holidays :(
:)

@bovirus
Copy link
Copy Markdown
Contributor

bovirus commented Jul 24, 2015

@donho
Thanks for the rely. Please if you can update english.xml.
I'm waiting that to align italian.xml.

@milipili
Copy link
Copy Markdown
Contributor

milipili commented Jul 24, 2015

Never far away ! :)

On 24 Jul 2015, at 14:12, Don HO notifications@github.com wrote:

while @milipili is in holidays :(
:)

@batagy
Copy link
Copy Markdown
Contributor Author

batagy commented Aug 3, 2015

Hi Don,
Yes, all are checked. :) They are not invalid.

Below appears in English, if translation not included:
Under StylerDialog title=“Styler Dialog”
Item id="1" name="&OK"/
Item id="2" name="&Cancel"/

Below 3 items are only appearing in menu if “Customize Toolbar” plugin is installed!
Under Commands
Item id="44012" name=“Hide Line Number Margin”/
Item id="44013" name=“Hide Bookmark Margin”/
Item id="44014" name=“Hide Folder Margin”/

The rest are valid.

Actually you can find the discussion topic here:
https://notepad-plus-plus.org/community/topic/164/unofficial-strings-for-translations

Regards
György

@batagy
Copy link
Copy Markdown
Contributor Author

batagy commented Aug 4, 2015

Hi Don,

One more question, that just noticed today. With 6.8.1 released today, I've noticed that below item appear now again in English:

Item id="41021" name="Restore Recent Closed File"

I saw in changelog that something was changed related to this item. Has it got a new a ID maybe?
Either please correct the code so that it should pickup the translation, or if it needs a change in english.xml then please change it!

Regards
György

@cmeriaux
Copy link
Copy Markdown
Contributor

cmeriaux commented Aug 4, 2015

@batagy Item id="41021" name="Restore Recent Closed File" is present since commit :

Revision: 2968fb9
Author: Lin Xiao prclx323800@gmail.com
Date: 10/05/2015 14:00:00
Message:

Translate "Restore Recent Closed File"

Modified: PowerEditor/installer/nativeLang/chinese.xml
Modified: PowerEditor/installer/nativeLang/chineseSimplified.xml
Modified: PowerEditor/installer/nativeLang/english.xml
Modified: PowerEditor/installer/nativeLang/english_customizable.xml

@batagy
Copy link
Copy Markdown
Contributor Author

batagy commented Aug 4, 2015

@cmeriaux
Yes it's present , and it was indeed fixed not long ango, probably around 2015-05-10 which you refer.
But currently it went bad again, again not translated as it was before that patch.

So now, the translation is not picked up, even if it's included.

@Rikk
Copy link
Copy Markdown
Contributor

Rikk commented Aug 4, 2015

Looks like @donho forced it to appear defined the initial value in english¹, I think the problem is that it is not updated with translation after Npp initialization.
¹a958b01#diff-35d82bdf4e1fdc62d667eb514cbc8cd2R87

@Rikk Rikk mentioned this pull request Aug 4, 2015
Closed
@donho
Copy link
Copy Markdown
Member

donho commented Aug 16, 2015

@batagy
Plugin translations will never be in localization file - not only because of maintenance problem, but especially the id of plugin commands are assigned dynamically.

English is updated in b94767f

@donho donho closed this Aug 16, 2015
batagy added a commit to batagy/notepad-plus-plus that referenced this pull request Aug 20, 2015
@batagy
Add 2 missing translatable items to original XML
7611806 
This is an attempt to add the complete, currently known unofficial strings to original english.xml language template. For version 6.8.2. Don Ho should review them, and make them official. These 2 item remained from notepad-plus-plus#542, not sure why it was not accepted.
@batagy batagy mentioned this pull request Aug 20, 2015
Closed
@batagy batagy mentioned this pull request Feb 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@donho donho

Labels

enhancement Proposed enhancements of existing features translation Issues or PRs related to translation of N++ UI

Projects

None yet

Milestone

6.x

Development

Successfully merging this pull request may close these issues.

6 participants

@batagy @Rikk @bovirus @milipili @donho @cmeriaux