Skip to content

cmake config update#3918

Closed
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
chcg:cmake_update
Closed

cmake config update#3918
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
chcg:cmake_update

Conversation

@chcg
Copy link
Copy Markdown
Contributor

@chcg chcg commented Nov 25, 2017

  • update of cmake config to reflect the vs proj changes since the last update

@chcg
Copy link
Copy Markdown
Contributor Author

chcg commented Nov 5, 2019

See https://ci.appveyor.com/project/chcg/notepad-plus-plus/builds/28639632 for a testbuild with cmake. The mingw variant needs the changes from #4145 to complete successfully.

@donho donho self-assigned this Nov 7, 2019
@donho
Copy link
Copy Markdown
Member

donho commented Nov 7, 2019

@chcg Since vcproj files and makefile are maintained now, what's the point of CMakeList.txt ?

@chcg
Copy link
Copy Markdown
Contributor Author

chcg commented Nov 8, 2019

By usage of cmake you could created make files for a lot of more build systems than just current MS vsproject or mingw make. You could generate vsproj files for different VS versions, jom, nmake, make, ninja, etc, see https://cmake.org/cmake/help/latest/manual/cmake-generators.7.html.

Additionally it would be possible to add a packaging step via the cmake part cpack (https://cmake.org/cmake/help/latest/manual/cpack-generators.7.html#manual:cpack-generators(7))

But in the end that all just makes sense if it is maintained at least a little bit.

@donho donho added the accepted label Nov 8, 2019
@donho donho closed this in 9bba129 Nov 8, 2019
@chcg chcg deleted the cmake_update branch January 2, 2021 09:30
iczelia pushed a commit to iczelia/notepad-plus-plus that referenced this pull request Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants