Skip to content

Add Support Highlight for 3.5.0+ Syntax.#2650

Closed
AraHaan wants to merge 1 commit intonotepad-plus-plus:masterfrom
AraHaan:AraHaan-patch-1
Closed

Add Support Highlight for 3.5.0+ Syntax.#2650
AraHaan wants to merge 1 commit intonotepad-plus-plus:masterfrom
AraHaan:AraHaan-patch-1

Conversation

@AraHaan
Copy link
Copy Markdown
Contributor

@AraHaan AraHaan commented Dec 7, 2016

This adds in highlighting for Python 3.5.0+ users who uses async def and awaits for coroutines.

These keywords are also planned to change in 3.6.0 as well with PEP-530.

http://www.python.org/dev/peps/pep-0530

This fixes #2640.

Note: this only adds in to 1 line the following keywords to the python setting:
async
await

@dail8859
Copy link
Copy Markdown
Contributor

dail8859 commented Dec 7, 2016

You just have to edit notepad-plus-plus/PowerEditor/src/langs.model.xml

For an example you can take a look at this PR's changes.

@AraHaan
Copy link
Copy Markdown
Contributor Author

AraHaan commented Dec 7, 2016

oh I see.

This adds in highlighting for Python 3.5.0+ users who uses ``async def`` and ``await``s for coroutines.

These keywords are also planned to change in 3.6.0 as well with PEP-530.

http://www.python.org/dev/peps/pep-0530
@AraHaan
Copy link
Copy Markdown
Contributor Author

AraHaan commented Dec 7, 2016

ok, I also squashed the commits into one as well.

@AraHaan
Copy link
Copy Markdown
Contributor Author

AraHaan commented Dec 14, 2016

@dail8859 mind reviewing this please to see if this is ready to merge?

@dail8859
Copy link
Copy Markdown
Contributor

dail8859 commented Dec 14, 2016

LGTM, but @donho is the one who will have to decide if it gets merged.

@donho donho self-assigned this Feb 18, 2017
@donho donho added the accepted label Feb 18, 2017
@donho donho added this to the 7.x (master) milestone Feb 18, 2017
@donho donho closed this in 855e581 Feb 18, 2017
@AraHaan AraHaan deleted the AraHaan-patch-1 branch February 18, 2017 21:41
iczelia pushed a commit to iczelia/notepad-plus-plus that referenced this pull request Jan 17, 2021
This adds in highlighting for Python 3.5.0+ users who uses "async def" and
"await"'s for coroutines.
These keywords are also planned to change in 3.6.0 as well with PEP-530.
http://www.python.org/dev/peps/pep-0530

Closes notepad-plus-plus#2650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Python 3.5 syntax to Python in langs.model.xml

3 participants