Add contextual keywords to C# word list#2416
Closed
dail8859 wants to merge 1 commit intonotepad-plus-plus:masterfrom
Closed
Add contextual keywords to C# word list#2416dail8859 wants to merge 1 commit intonotepad-plus-plus:masterfrom
dail8859 wants to merge 1 commit intonotepad-plus-plus:masterfrom
Conversation
SinghRajenM
pushed a commit
to SinghRajenM/notepad-plus-plus
that referenced
this pull request
Nov 13, 2016
chcg
added a commit
to chcg/notepad-plus-plus
that referenced
this pull request
Jun 9, 2025
Release 5.5.7 (https://www.scintilla.org/scintilla557.zip) Released 8 June 2025. Add SCI_SCROLLVERTICAL method to restore view position and maintain it while performing line wrapping. Add SC_UNDO_SELECTION_HISTORY_SCROLL flag to SCI_SETUNDOSELECTIONHISTORY which controls whether undo and redo restore vertical scroll position. Tweak SC_MARK_BAR to be slightly wider by using next higher whole pixel instead of next lower for margin width / 3. Scale images in autocompletion lists with SCI_AUTOCSETIMAGESCALE to match high DPI screens. Initially only on GTK and Qt. Fix wrapping bug for UTF-8 where \r\n could wrap between the characters. Notepad++ Pull Request notepad-plus-plus#16373. Fix crash during painting when scroll bars changed. Bug notepad-plus-plus#2481. On GTK, reset vertical scroll bar synchronously in SCI_SETDOCPOINTER to fix bug where scroll position not restored in non-wrap mode. Bug notepad-plus-plus#2416. On GTK, fix IME problem when tentative composition interfered with delete surrounding. Feature notepad-plus-plus#1476. On GTK, update IME cursor position inside retrieve surrounding to better position candidate window. Feature notepad-plus-plus#1488. Release 5.4.5 (https://www.scintilla.org/lexilla545.zip) Released 8 June 2025. Dart: Add error state SCE_DART_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315. Makefile: Add a keyword list to makefile lexer to highlight GNU Make directives like 'ifdef' and 'vpath' as SCE_MAKE_PREPROCESSOR since these are similar to NMAKE directives like '!IFDEF'. Nix: Add error state SCE_NIX_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315. TOML: Add error state SCE_TOML_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315. Zig: Add error state SCE_ZIG_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315.
chcg
added a commit
to chcg/notepad-plus-plus
that referenced
this pull request
Jun 9, 2025
Release 5.5.7 (https://www.scintilla.org/scintilla557.zip) Released 8 June 2025. Add SCI_SCROLLVERTICAL method to restore view position and maintain it while performing line wrapping. Add SC_UNDO_SELECTION_HISTORY_SCROLL flag to SCI_SETUNDOSELECTIONHISTORY which controls whether undo and redo restore vertical scroll position. Tweak SC_MARK_BAR to be slightly wider by using next higher whole pixel instead of next lower for margin width / 3. Scale images in autocompletion lists with SCI_AUTOCSETIMAGESCALE to match high DPI screens. Initially only on GTK and Qt. Fix wrapping bug for UTF-8 where \r\n could wrap between the characters. Notepad++ Pull Request notepad-plus-plus#16373. Fix crash during painting when scroll bars changed. Bug notepad-plus-plus#2481. On GTK, reset vertical scroll bar synchronously in SCI_SETDOCPOINTER to fix bug where scroll position not restored in non-wrap mode. Bug notepad-plus-plus#2416. On GTK, fix IME problem when tentative composition interfered with delete surrounding. Feature notepad-plus-plus#1476. On GTK, update IME cursor position inside retrieve surrounding to better position candidate window. Feature notepad-plus-plus#1488. Release 5.4.5 (https://www.scintilla.org/lexilla545.zip) Released 8 June 2025. Dart: Add error state SCE_DART_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315. Makefile: Add a keyword list to makefile lexer to highlight GNU Make directives like 'ifdef' and 'vpath' as SCE_MAKE_PREPROCESSOR since these are similar to NMAKE directives like '!IFDEF'. Nix: Add error state SCE_NIX_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315. TOML: Add error state SCE_TOML_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315. Zig: Add error state SCE_ZIG_STRINGEOL for unterminated string. Pull request notepad-plus-plus#315.
donho
pushed a commit
that referenced
this pull request
Jun 13, 2025
Release 5.5.7 (https://www.scintilla.org/scintilla557.zip) Released 8 June 2025 1. Add SCI_SCROLLVERTICAL method to restore view position and maintain it while performing line wrapping. 2. Add SC_UNDO_SELECTION_HISTORY_SCROLL flag to SCI_SETUNDOSELECTIONHISTORY which controls whether undo and redo restore vertical scroll position. 3. Tweak SC_MARK_BAR to be slightly wider by using next higher whole pixel instead of next lower for margin width / 3. 4. Scale images in autocompletion lists with SCI_AUTOCSETIMAGESCALE to match high DPI screens. Initially only on GTK and Qt. 5. Fix wrapping bug for UTF-8 where \r\n could wrap between the characters. Notepad++ Pull Request #16373. 6. Fix crash during painting when scroll bars changed. Bug #2481. 7. On GTK, reset vertical scroll bar synchronously in SCI_SETDOCPOINTER to fix bug where scroll position not restored in non-wrap mode. Bug #2416. 8. On GTK, fix IME problem when tentative composition interfered with delete surrounding. Feature #1476. 9. On GTK, update IME cursor position inside retrieve surrounding to better position candidate window. Feature #1488. Release 5.4.5 (https://www.scintilla.org/lexilla545.zip) Released 8 June 2025 1. Dart: Add error state SCE_DART_STRINGEOL for unterminated string. Pull request #315. 2. Makefile: Add a keyword list to makefile lexer to highlight GNU Make directives like 'ifdef' and 'vpath' as SCE_MAKE_PREPROCESSOR since these are similar to NMAKE directives like '!IFDEF'. 3. Nix: Add error state SCE_NIX_STRINGEOL for unterminated string. Pull request #315. 4. TOML: Add error state SCE_TOML_STRINGEOL for unterminated string. Pull request #315. 5. Zig: Add error state SCE_ZIG_STRINGEOL for unterminated string. Pull request #315. Close #16649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2413
This adds C# contextual keywords. As discussed in the referenced issue, these words aren't actually reserved keywords. Meaning that in some contexts they are not actually keywords. Since the C# lexer is not able to distinguish whey they are contextually appropriate, it will always highlight them. I feel it would be rare to actually see these contextual keywords elsewhere in source code (I would assume it is best practice not to use them anyways). If there are objects to adding all of these contextual keywords in fear it may inappropriately highlight words, then I'd suggest at least adding a subset of them.