Skip to content

Improve tab alignment in Shortcut Mapper#2160

Closed
A-R-C-A wants to merge 1 commit intonotepad-plus-plus:masterfrom
A-R-C-A:TabAlignment
Closed

Improve tab alignment in Shortcut Mapper#2160
A-R-C-A wants to merge 1 commit intonotepad-plus-plus:masterfrom
A-R-C-A:TabAlignment

Conversation

@A-R-C-A
Copy link
Copy Markdown
Contributor

@A-R-C-A A-R-C-A commented Aug 11, 2016

More accurate alignment of tabs to babygrid.

@A-R-C-A
Copy link
Copy Markdown
Contributor Author

A-R-C-A commented Aug 11, 2016

@MAPJe71
It seems you have improved your function list parsers. Can you please upload your functionList.xml here or make a PR for it?

@MAPJe71
Copy link
Copy Markdown
Contributor

MAPJe71 commented Aug 11, 2016

A bit off-topic here ;) but here's link to my functionList.xml.

@A-R-C-A
Copy link
Copy Markdown
Contributor Author

A-R-C-A commented Aug 11, 2016

thanks

@donho donho added the accepted label Aug 13, 2016
@donho donho added this to the 6.x milestone Aug 13, 2016
@donho donho self-assigned this Aug 13, 2016
@donho donho closed this in 5f3225b Aug 14, 2016
@donho
Copy link
Copy Markdown
Member

donho commented Aug 14, 2016

@MAPJe71 does your functionList.xml is compatible with Notepad++ official release completely?

@MAPJe71
Copy link
Copy Markdown
Contributor

MAPJe71 commented Aug 14, 2016

@donho
All parsers should be compatible. Unfortunately most of the changed official-release/stock parsers appear not to be functional. At the time they were changed I used Scintilla 3.56 with Boost 1.58 for use with my FunctionList patch. More recent changes to the stock parsers (see date tags in file) are done with official release Notepad++.
Unless you want a sh!t load of complaints about FunctionList do NOT USE my functionList.xml AS IS. ;)

@A-R-C-A A-R-C-A deleted the TabAlignment branch August 15, 2016 01:11
@donho
Copy link
Copy Markdown
Member

donho commented Aug 15, 2016

Unless you want a sh!t load of complaints about FunctionList do NOT USE my functionList.xml AS IS. ;)

Sorry, I have problem to understand double nagative. Are you telling me that your function list is better than current one?

@MAPJe71
Copy link
Copy Markdown
Contributor

MAPJe71 commented Aug 15, 2016

I advise you NOT to use my functionList.xml as is.

Some parsers are improved IMO e.g. Batch / Command Shell, INI Section and Python;
Some are added and optimized for my use e.g. XML Function List
Some are possibly improved (possibly because I did not get a response yet for validation) e.g. #1919;
Some are added to be able to help others e.g. #2045, Community #9725, Community #12126;
Some are optimized for my SourceForge #548 patch and do not work correctly without it i.e. not functional;

I do not use all the parsers myself, the ones I do use regularly function of course ;) (i.e. Batch / Command Shell, INI Section, Python and XML Function List).

@donho
Copy link
Copy Markdown
Member

donho commented Aug 16, 2016

@MAPJe71 Thank you for the elaboration.
In this case, could you do a PR for the parsers that we are sure they are better than current (with the header in comment which gives the explicite explanation)?

Regarding your SF's PR, I have checked it - the reason that the PR was not accepted is the dificulty of its integretion - it was kind of rewritten and hard to tell what is fixed/enhancend.
I believe some enhancements have been done in your patch. What I want to make sure is there'll be no regression. If you could do some effort to do PR again (without reformatting and change of code structure) , I'll check it again (and sorry for the inconvenience).

@MAPJe71
Copy link
Copy Markdown
Contributor

MAPJe71 commented Aug 16, 2016

@donho

... do a PR for the parsers ...

Sure no problem.
Do you mean an explanation for the improvements or the regular expressions or both?

Regarding SF's PR ...

Yep, I figured that would have been the case. There's a contributing guideline now ;)
I will create a separate PR for this and include the optimized parsers which dependent on this patch (with explanatory comment, before/after comparison)

@donho
Copy link
Copy Markdown
Member

donho commented Aug 16, 2016

Do you mean an explanation for the improvements or the regular expressions or both?

Both. The improvements which work only for the current Notepad++ of course.

I will create a separate PR for this and include the optimized parsers which dependent on this patch (with explanatory comment, before/after comparison

Thank you very much.

SinghRajenM pushed a commit to SinghRajenM/notepad-plus-plus that referenced this pull request Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants