Skip to content

adjust build for boost > 1.55 and vs2015#139

Closed
chcg wants to merge 13 commits intonotepad-plus-plus:masterfrom
chcg:detect_new_boost_build_dir
Closed

adjust build for boost > 1.55 and vs2015#139
chcg wants to merge 13 commits intonotepad-plus-plus:masterfrom
chcg:detect_new_boost_build_dir

Conversation

@chcg
Copy link
Contributor

@chcg chcg commented May 30, 2015

-- Regex:
-- Breaking change: corrected behavior of basic_regex<>::mark_count() to match existing documentation, basic_regex<>::subexpression(n) changed to match, see #9227
-- Fixed issue #8903.
-- Fixed documentation typos from #9283.
-- Fixed bug in collation code that failed if the locale generated collation strings with embedded nul's, see #9451.
-- Apply patch for unusual thread usage (no statically initiallized mutexes), see #9461.
-- Added better checks for invalid UTF-8 sequences, see #9473.

@NN---
Copy link
Contributor

NN--- commented May 30, 2015

Why not NuGet ?
IMO it is much easier to use it and you don't need any scripts nor to compiler it.

@chcg
Copy link
Contributor Author

chcg commented Jun 6, 2015

Not familiar with integration of nuget.
Scintilla itself added c++11 regex in the meantime, maybe dependency to boost could skipped completely.

@NN---
Copy link
Contributor

NN--- commented Jun 7, 2015

http://www.scintilla.org/ScintillaDoc.html
"When using a C++11 compliant compiler and runtime, it may be possible to use the runtime's implementation of by compiling Scintilla with CXX11_REGEX defined"

Basically it means that using Scintilla with standard regular expression can be sufficient.

@ariccio
Copy link
Contributor

ariccio commented Jun 8, 2015

When using a C++11 compliant compiler and runtime, it _may_ be possible to use the runtime's implementation of by compiling Scintilla with CXX11_REGEX defined

(emphasis mine)

Well, is it?

@ariccio
Copy link
Contributor

ariccio commented Jun 8, 2015

Side note:

implementation of by compiling

Grr. They're missing a word?

@NN---
Copy link
Contributor

NN--- commented Jun 8, 2015

As I mentioned in other issue, boost::regex can be PCRE while std::regex is not PCRE. So in any case boost is required.

@ariccio
Copy link
Contributor

ariccio commented Jun 8, 2015

For reference:

PCRE == Perl Compatible Regular Expressions

@chcg chcg mentioned this pull request Jun 16, 2015
@chcg chcg changed the title Detect new boost build dir adjust build for boost > 1.55 Jul 26, 2015
@chcg chcg changed the title adjust build for boost > 1.55 adjust build for boost > 1.55 and vs2015 Jul 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants