Avoid out-of bounds read access issue introduced with#1111
Closed
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
Closed
Avoid out-of bounds read access issue introduced with#1111chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
Conversation
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/187/files , see also comments added in the PR: String returned by SCI_GETWORDCHARS from scintilla is not null terminated, so check for strlen in isWordChar() below on listChar is dangerous as strlen accesses data after the buffer until the first following null is found in memory - seen with MS Application Verifier on x64 release - expected to also happen on win32 x86 release
Contributor
|
I agree with you. |
Contributor
|
(!!!) I hit this too! (I'll create the issue) |
Contributor
|
See also, my four comments on the commit: 037b41e#commitcomment-14399645 |
ariccio
added a commit
to ariccio/notepad-plus-plus
that referenced
this pull request
Nov 15, 2015
The original code was unnecessarily complex, did unnecessary work, and overran the listChar buffer. This is an alternative to notepad-plus-plus#1111, with more const, and simpler code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix on PR Fix smarthighlight #187
, see also comments added in the PR.
String returned by SCI_GETWORDCHARS from scintilla is not null terminated, so check for strlen in isWordChar() below on listChar is dangerous as strlen accesses data after the buffer until the first following null is found in memory