Skip to content

fix: rename staging to dev branch #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susanshi merged 4 commits into from
Apr 18, 2024
Merged

fix: rename staging to dev branch #1401

susanshi merged 4 commits into from
Apr 18, 2024

Conversation

@susanshi
Copy link
Collaborator

@susanshi susanshi commented Apr 17, 2024

Description

What this PR does / why we need it:

Suggestion to rename staging to dev branch to align with other open resource repo.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1396

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

susanshi
susanshi commented Apr 18, 2024
View reviewed changes
@codecov
Copy link

codecov bot commented Apr 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@cc7d780). Click here to learn what that means.

Additional details and impacted files 
@@          Coverage Diff           @@
##             dev    #1401   +/-   ##
======================================
  Coverage       ?   65.52%           
======================================
  Files          ?      109           
  Lines          ?     5570           
  Branches       ?        0           
======================================
  Hits           ?     3650           
  Misses         ?     1565           
  Partials       ?      355

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susanshi susanshi marked this pull request as ready for review April 18, 2024 04:18
binbin-li
binbin-li approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for updating it

@susanshi susanshi merged commit 4fed7a0 into notaryproject:dev Apr 18, 2024
akashsinghal pushed a commit that referenced this pull request Apr 25, 2024
@susanshi @binbin-li @akashsinghal
fix: rename staging to dev branch (#1401)
71f4ab7 
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@binbin-li binbin-li binbin-li approved these changes

@akashsinghal akashsinghal Awaiting requested review from akashsinghal akashsinghal is a code owner

@jimmyraywv jimmyraywv Awaiting requested review from jimmyraywv jimmyraywv is a code owner

@luisdlp luisdlp Awaiting requested review from luisdlp luisdlp is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: renaming staging branch to dev

2 participants

@susanshi @binbin-li