Skip to content

fix: enable workflow for staging #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susanshi merged 2 commits into from
Apr 11, 2024
Merged

fix: enable workflow for staging #1369

susanshi merged 2 commits into from
Apr 11, 2024

Conversation

@susanshi
Copy link
Collaborator

@susanshi susanshi commented Apr 5, 2024

Description

What this PR does / why we need it

Review which workflow should run for staging

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.20%. Comparing base (73ef709) to head (45f97fe).
Report is 5 commits behind head on staging.

Additional details and impacted files 
@@             Coverage Diff             @@
##           staging    #1369      +/-   ##
===========================================
- Coverage    65.31%   65.20%   -0.12%     
===========================================
  Files          105      105              
  Lines         5458     5521      +63     
===========================================
+ Hits          3565     3600      +35     
- Misses        1535     1567      +32     
+ Partials       358      354       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

akashsinghal
akashsinghal reviewed Apr 5, 2024
View reviewed changes
binbin-li
binbin-li approved these changes Apr 10, 2024
View reviewed changes
@susanshi susanshi merged commit 3872e05 into notaryproject:staging Apr 11, 2024
@susanshi susanshi deleted the stagingworkflow branch April 11, 2024 02:53
akashsinghal pushed a commit that referenced this pull request Apr 25, 2024
@susanshi @akashsinghal
fix: enable workflow for staging (#1369)
2b66e0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@binbin-li binbin-li binbin-li approved these changes

@akashsinghal akashsinghal akashsinghal approved these changes

@jimmyraywv jimmyraywv Awaiting requested review from jimmyraywv

@luisdlp luisdlp Awaiting requested review from luisdlp

@toddysm toddysm Awaiting requested review from toddysm

Assignees

@susanshi susanshi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@susanshi @binbin-li @akashsinghal