Skip to content

chore: add license header to files and github action workflow to check license#334

Merged
9 commits merged intomainfrom
unknown repository
Jul 18, 2023
Merged

chore: add license header to files and github action workflow to check license#334
9 commits merged intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 12, 2023

Resolves #322

This PR should be reviewed/merged after notaryproject/notation-core-go#154.

Patrick Zheng added 2 commits July 12, 2023 14:53
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #334 (4c2d684) into main (052e405) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files          23       23           
  Lines        2203     2203           
=======================================
  Hits         1648     1648           
  Misses        437      437           
  Partials      118      118           
Impacted Files Coverage Δ
config/base.go 63.63% <ø> (ø)
config/config.go 44.44% <ø> (ø)
config/keys.go 71.89% <ø> (ø)
dir/fs.go 66.66% <ø> (ø)
dir/path.go 88.88% <ø> (ø)
errors.go 13.33% <ø> (ø)
internal/envelope/envelope.go 43.47% <ø> (ø)
notation.go 64.81% <ø> (ø)
plugin/manager.go 77.77% <ø> (ø)
plugin/manager_unix.go 100.00% <ø> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ghost ghost self-assigned this Jul 12, 2023
@ghost ghost added the enhancement New feature or request label Jul 12, 2023
@ghost ghost added this to the 1.0.0 milestone Jul 12, 2023
@ghost ghost changed the title feat: add license header to files and github action to check license headers feat: add license header to files and github action workflow to check lincese Jul 12, 2023
@ghost ghost changed the title feat: add license header to files and github action workflow to check lincese feat: add license header to files and github action workflow to check license Jul 12, 2023
shizhMSFT
shizhMSFT previously approved these changes Jul 12, 2023
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost changed the title feat: add license header to files and github action workflow to check license chore: add license header to files and github action workflow to check license Jul 12, 2023
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 3 commits July 12, 2023 18:51
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from shizhMSFT July 12, 2023 11:23
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from shizhMSFT July 13, 2023 07:54
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR must be merged after notaryproject/notation-core-go#154

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 3981f69 into notaryproject:main Jul 18, 2023
@ghost ghost deleted the license branch July 18, 2023 02:12
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check the license header for notation-go and its dependencies

4 participants