-
Notifications
You must be signed in to change notification settings - Fork 91
fix(ci): update goreleaser to use --clean flag #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shizhMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
=======================================
Coverage 71.34% 71.34%
=======================================
Files 45 45
Lines 2174 2174
=======================================
Hits 1551 1551
Misses 429 429
Partials 194 194 ☔ View full report in Codecov by Sentry. |
priteshbandi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix: replace `--rm-dist` with `--clean` Goreleaser was updated to v6.0.0 in notaryproject#962. However the flag `--rm-dist` was deprecated in the latest version. Please see the details in the official document: https://goreleaser.com/deprecations/#-rm-dist Test: the test release was successful Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Fix: replace `--rm-dist` with `--clean` Goreleaser was updated to v6.0.0 in notaryproject#962. However the flag `--rm-dist` was deprecated in the latest version. Please see the details in the official document: https://goreleaser.com/deprecations/#-rm-dist Test: the test release was successful Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Fix:
--rm-distwith--cleanGoreleaser was updated to v6.0.0 in #962. However the flag
--rm-distwas deprecated in the latest version. Please see the details in the official document: https://goreleaser.com/deprecations/#-rm-distTest:
Signed-off-by: Junjie Gao junjiegao@microsoft.com