Skip to content

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Jun 11, 2024

Fix:

  • replace --rm-dist with --clean

Goreleaser was updated to v6.0.0 in #962. However the flag --rm-dist was deprecated in the latest version. Please see the details in the official document: https://goreleaser.com/deprecations/#-rm-dist

Test:

Signed-off-by: Junjie Gao junjiegao@microsoft.com

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.34%. Comparing base (f8a279c) to head (aae61f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files          45       45           
  Lines        2174     2174           
=======================================
  Hits         1551     1551           
  Misses        429      429           
  Partials      194      194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 3e9e9e9 into notaryproject:main Jun 11, 2024
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Fix: replace `--rm-dist` with `--clean`

Goreleaser was updated to v6.0.0 in notaryproject#962. However the flag `--rm-dist` was deprecated in the latest version. Please see the details in the official document: https://goreleaser.com/deprecations/#-rm-dist
Test: the test release was successful

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Fix: replace `--rm-dist` with `--clean`

Goreleaser was updated to v6.0.0 in notaryproject#962. However the flag `--rm-dist` was deprecated in the latest version. Please see the details in the official document: https://goreleaser.com/deprecations/#-rm-dist
Test: the test release was successful

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants